Issue 129353002: Parse /proc/<pid>/stats fields as int64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 129353002: Parse /proc/<pid>/stats fields as int64 (Closed)

Created:
6 years, 11 months ago by sheu

Modified:
6 years, 11 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Parse /proc/<pid>/stats fields as int64 Some entries are 64 bits wide, and will overflow on occasion. In particular, VM_STARTTIME will overflow a 32-bit int on long-running systems. BUG=332491 TEST=local build, run on desktop Linux Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243733

Patch Set 1 : 046181fb Initial. #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -24 lines)			Patch
M	base/process/internal_linux.h	View	1 chunk	+7 lines, -8 lines	0 comments	Download
M	base/process/internal_linux.cc	View	2 chunks	+6 lines, -7 lines	0 comments	Download
M	base/process/process_handle_linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/process/process_info_linux.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/process/process_iterator_linux.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/process/process_metrics_linux.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sheu

Fun times when running on a machine with 282 days' uptime. darin@: PTAL. Thanks!

6 years, 11 months ago (2014-01-08 21:10:42 UTC) #1

darin (slow to review)

LGTM Any thoughts on how to write a test for this?

6 years, 11 months ago (2014-01-08 22:33:28 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheu@chromium.org/129353002/30001

6 years, 11 months ago (2014-01-08 22:39:14 UTC) #3

Message was sent while issue was closed.

Change committed as 243733

Expand Messages | Collapse Messages