Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Side by Side Diff: content/browser/renderer_host/media/audio_input_sync_writer.cc

Issue 1293503002: Check buffer index in shared memory for input audio. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/media/audio_input_sync_writer.h" 5 #include "content/browser/renderer_host/media/audio_input_sync_writer.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/memory/shared_memory.h" 9 #include "base/memory/shared_memory.h"
10 #include "content/browser/renderer_host/media/media_stream_manager.h" 10 #include "content/browser/renderer_host/media/media_stream_manager.h"
11 11
12 using media::AudioBus; 12 using media::AudioBus;
13 13
14 namespace content { 14 namespace content {
15 15
16 AudioInputSyncWriter::AudioInputSyncWriter(base::SharedMemory* shared_memory, 16 AudioInputSyncWriter::AudioInputSyncWriter(base::SharedMemory* shared_memory,
17 int shared_memory_segment_count, 17 int shared_memory_segment_count,
18 const media::AudioParameters& params) 18 const media::AudioParameters& params)
19 : shared_memory_(shared_memory), 19 : shared_memory_(shared_memory),
20 shared_memory_segment_count_(shared_memory_segment_count), 20 shared_memory_segment_count_(shared_memory_segment_count),
21 current_segment_id_(0), 21 current_segment_id_(0),
22 creation_time_(base::Time::Now()), 22 creation_time_(base::Time::Now()),
23 audio_bus_memory_size_(AudioBus::CalculateMemorySize(params)) { 23 audio_bus_memory_size_(AudioBus::CalculateMemorySize(params)),
24 next_buffer_id_(0) {
24 DCHECK_GT(shared_memory_segment_count, 0); 25 DCHECK_GT(shared_memory_segment_count, 0);
25 DCHECK_EQ(shared_memory->requested_size() % shared_memory_segment_count, 0u); 26 DCHECK_EQ(shared_memory->requested_size() % shared_memory_segment_count, 0u);
26 shared_memory_segment_size_ = 27 shared_memory_segment_size_ =
27 shared_memory->requested_size() / shared_memory_segment_count; 28 shared_memory->requested_size() / shared_memory_segment_count;
28 DVLOG(1) << "SharedMemory::requested_size: " 29 DVLOG(1) << "SharedMemory::requested_size: "
29 << shared_memory->requested_size(); 30 << shared_memory->requested_size();
30 DVLOG(1) << "shared_memory_segment_count: " << shared_memory_segment_count; 31 DVLOG(1) << "shared_memory_segment_count: " << shared_memory_segment_count;
31 DVLOG(1) << "audio_bus_memory_size: " << audio_bus_memory_size_; 32 DVLOG(1) << "audio_bus_memory_size: " << audio_bus_memory_size_;
32 33
33 // Create vector of audio buses by wrapping existing blocks of memory. 34 // Create vector of audio buses by wrapping existing blocks of memory.
34 uint8* ptr = static_cast<uint8*>(shared_memory_->memory()); 35 uint8* ptr = static_cast<uint8*>(shared_memory_->memory());
35 for (int i = 0; i < shared_memory_segment_count; ++i) { 36 for (int i = 0; i < shared_memory_segment_count; ++i) {
36 media::AudioInputBuffer* buffer = 37 media::AudioInputBuffer* buffer =
37 reinterpret_cast<media::AudioInputBuffer*>(ptr); 38 reinterpret_cast<media::AudioInputBuffer*>(ptr);
38 scoped_ptr<media::AudioBus> audio_bus = 39 scoped_ptr<media::AudioBus> audio_bus =
39 media::AudioBus::WrapMemory(params, buffer->audio); 40 media::AudioBus::WrapMemory(params, buffer->audio);
40 audio_buses_.push_back(audio_bus.release()); 41 audio_buses_.push_back(audio_bus.release());
41 ptr += shared_memory_segment_size_; 42 ptr += shared_memory_segment_size_;
42 } 43 }
43 } 44 }
44 45
45 AudioInputSyncWriter::~AudioInputSyncWriter() {} 46 AudioInputSyncWriter::~AudioInputSyncWriter() {}
46 47
47 // TODO(henrika): Combine into one method (including Write).
48 void AudioInputSyncWriter::UpdateRecordedBytes(uint32 bytes) {
49 socket_->Send(&bytes, sizeof(bytes));
50 }
51
52 void AudioInputSyncWriter::Write(const media::AudioBus* data, 48 void AudioInputSyncWriter::Write(const media::AudioBus* data,
53 double volume, 49 double volume,
54 bool key_pressed) { 50 bool key_pressed,
51 uint32 hardware_delay_bytes) {
55 #if !defined(OS_ANDROID) 52 #if !defined(OS_ANDROID)
56 static const base::TimeDelta kLogDelayThreadhold = 53 static const base::TimeDelta kLogDelayThreadhold =
57 base::TimeDelta::FromMilliseconds(500); 54 base::TimeDelta::FromMilliseconds(500);
58 55
59 std::ostringstream oss; 56 std::ostringstream oss;
60 if (last_write_time_.is_null()) { 57 if (last_write_time_.is_null()) {
61 // This is the first time Write is called. 58 // This is the first time Write is called.
62 base::TimeDelta interval = base::Time::Now() - creation_time_; 59 base::TimeDelta interval = base::Time::Now() - creation_time_;
63 oss << "AISW::Write: audio input data received for the first time: delay " 60 oss << "AISW::Write: audio input data received for the first time: delay "
64 "= " << interval.InMilliseconds() << "ms"; 61 "= " << interval.InMilliseconds() << "ms";
(...skipping 14 matching lines...) Expand all
79 #endif 76 #endif
80 77
81 // Write audio parameters to shared memory. 78 // Write audio parameters to shared memory.
82 uint8* ptr = static_cast<uint8*>(shared_memory_->memory()); 79 uint8* ptr = static_cast<uint8*>(shared_memory_->memory());
83 ptr += current_segment_id_ * shared_memory_segment_size_; 80 ptr += current_segment_id_ * shared_memory_segment_size_;
84 media::AudioInputBuffer* buffer = 81 media::AudioInputBuffer* buffer =
85 reinterpret_cast<media::AudioInputBuffer*>(ptr); 82 reinterpret_cast<media::AudioInputBuffer*>(ptr);
86 buffer->params.volume = volume; 83 buffer->params.volume = volume;
87 buffer->params.size = audio_bus_memory_size_; 84 buffer->params.size = audio_bus_memory_size_;
88 buffer->params.key_pressed = key_pressed; 85 buffer->params.key_pressed = key_pressed;
86 buffer->params.hardware_delay_bytes = hardware_delay_bytes;
87 buffer->params.id = next_buffer_id_++;
89 88
90 // Copy data from the native audio layer into shared memory using pre- 89 // Copy data from the native audio layer into shared memory using pre-
91 // allocated audio buses. 90 // allocated audio buses.
92 media::AudioBus* audio_bus = audio_buses_[current_segment_id_]; 91 media::AudioBus* audio_bus = audio_buses_[current_segment_id_];
93 data->CopyTo(audio_bus); 92 data->CopyTo(audio_bus);
94 93
94 socket_->Send(&current_segment_id_, sizeof(current_segment_id_));
95
95 if (++current_segment_id_ >= shared_memory_segment_count_) 96 if (++current_segment_id_ >= shared_memory_segment_count_)
96 current_segment_id_ = 0; 97 current_segment_id_ = 0;
97 } 98 }
98 99
99 void AudioInputSyncWriter::Close() { 100 void AudioInputSyncWriter::Close() {
100 socket_->Close(); 101 socket_->Close();
101 } 102 }
102 103
103 bool AudioInputSyncWriter::Init() { 104 bool AudioInputSyncWriter::Init() {
104 socket_.reset(new base::CancelableSyncSocket()); 105 socket_.reset(new base::CancelableSyncSocket());
105 foreign_socket_.reset(new base::CancelableSyncSocket()); 106 foreign_socket_.reset(new base::CancelableSyncSocket());
106 return base::CancelableSyncSocket::CreatePair(socket_.get(), 107 return base::CancelableSyncSocket::CreatePair(socket_.get(),
107 foreign_socket_.get()); 108 foreign_socket_.get());
108 } 109 }
109 110
110 bool AudioInputSyncWriter::PrepareForeignSocket( 111 bool AudioInputSyncWriter::PrepareForeignSocket(
111 base::ProcessHandle process_handle, 112 base::ProcessHandle process_handle,
112 base::SyncSocket::TransitDescriptor* descriptor) { 113 base::SyncSocket::TransitDescriptor* descriptor) {
113 return foreign_socket_->PrepareTransitDescriptor(process_handle, descriptor); 114 return foreign_socket_->PrepareTransitDescriptor(process_handle, descriptor);
114 } 115 }
115 116
116 117
117 } // namespace content 118 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698