Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: src/messages.h

Issue 1293493004: Unify symbols sharing across native scripts and runtime. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/macros.py ('k') | src/messages.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/messages.h
diff --git a/src/messages.h b/src/messages.h
index 5d56ceb1c8c499c0a5139ed53028e2e80bb8dfd3..14f1dcf3ee92879986b462402da579e6291c974c 100644
--- a/src/messages.h
+++ b/src/messages.h
@@ -47,23 +47,23 @@ class MessageLocation {
class CallSite {
public:
- CallSite(Handle<Object> receiver, Handle<JSFunction> fun, int pos)
- : receiver_(receiver), fun_(fun), pos_(pos) {}
+ CallSite(Isolate* isolate, Handle<JSObject> call_site_obj);
- Handle<Object> GetFileName(Isolate* isolate);
- Handle<Object> GetFunctionName(Isolate* isolate);
- Handle<Object> GetScriptNameOrSourceUrl(Isolate* isolate);
- Handle<Object> GetMethodName(Isolate* isolate);
+ Handle<Object> GetFileName();
+ Handle<Object> GetFunctionName();
+ Handle<Object> GetScriptNameOrSourceUrl();
+ Handle<Object> GetMethodName();
// Return 1-based line number, including line offset.
- int GetLineNumber(Isolate* isolate);
+ int GetLineNumber();
// Return 1-based column number, including column offset if first line.
- int GetColumnNumber(Isolate* isolate);
- bool IsNative(Isolate* isolate);
- bool IsToplevel(Isolate* isolate);
- bool IsEval(Isolate* isolate);
- bool IsConstructor(Isolate* isolate);
+ int GetColumnNumber();
+ bool IsNative();
+ bool IsToplevel();
+ bool IsEval();
+ bool IsConstructor();
private:
+ Isolate* isolate_;
Handle<Object> receiver_;
Handle<JSFunction> fun_;
int pos_;
« no previous file with comments | « src/macros.py ('k') | src/messages.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698