Unify symbols sharing across native scripts and runtime.

src/heap/heap.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_HEAP_HEAP_H_
 #define V8_HEAP_HEAP_H_
 
 #include <cmath>
 #include <map>
 
@@ skipping 246 matching lines @@
   V(string_string, "string")                                   \
   V(String_string, "String")                                   \
   V(symbol_string, "symbol")                                   \
   V(Symbol_string, "Symbol")                                   \
   V(Map_string, "Map")                                         \
   V(Set_string, "Set")                                         \
   V(WeakMap_string, "WeakMap")                                 \
   V(WeakSet_string, "WeakSet")                                 \
   V(for_string, "for")                                         \
   V(for_api_string, "for_api")                                 \
-  V(for_intern_string, "for_intern")                           \
-  V(private_api_string, "private_api")                         \
-  V(private_intern_string, "private_intern")                   \
   V(Date_string, "Date")                                       \
   V(char_at_string, "CharAt")                                  \
   V(undefined_string, "undefined")                             \
   V(value_of_string, "valueOf")                                \
   V(stack_string, "stack")                                     \
   V(toJSON_string, "toJSON")                                   \
   V(KeyedLoadMonomorphic_string, "KeyedLoadMonomorphic")       \
   V(KeyedStoreMonomorphic_string, "KeyedStoreMonomorphic")     \
   V(illegal_access_string, "illegal access")                   \
   V(cell_value_string, "%cell_value")                          \
@@ skipping 10 matching lines @@
   V(done_string, "done")                                       \
   V(value_string, "value")                                     \
   V(next_string, "next")                                       \
   V(byte_length_string, "byteLength")                          \
   V(byte_offset_string, "byteOffset")                          \
   V(minus_zero_string, "-0")                                   \
   V(Array_string, "Array")                                     \
   V(Error_string, "Error")                                     \
   V(RegExp_string, "RegExp")
 
-#define PRIVATE_SYMBOL_LIST(V)      \
-  V(nonextensible_symbol)           \
-  V(sealed_symbol)                  \
-  V(hash_code_symbol)               \
-  V(frozen_symbol)                  \
-  V(nonexistent_symbol)             \
-  V(elements_transition_symbol)     \
-  V(observed_symbol)                \
-  V(uninitialized_symbol)           \
-  V(megamorphic_symbol)             \
-  V(premonomorphic_symbol)          \
-  V(stack_trace_symbol)             \
-  V(detailed_stack_trace_symbol)    \
-  V(normal_ic_symbol)               \
-  V(home_object_symbol)             \
-  V(intl_initialized_marker_symbol) \
-  V(intl_impl_object_symbol)        \
-  V(promise_debug_marker_symbol)    \
-  V(promise_has_handler_symbol)     \
-  V(class_start_position_symbol)    \
-  V(class_end_position_symbol)      \
-  V(error_start_pos_symbol)         \
-  V(error_end_pos_symbol)           \
-  V(error_script_symbol)            \
-  V(internal_error_symbol)
+#define PRIVATE_SYMBOL_LIST(V)              \

[Michael Lippautz, 2015/08/19 13:41:13]

I wonder whether it would (at some point) make sense to move this somewhere
else? We create strong roots for those symbols but that's all the heap cares
about ;)

+  V(array_iteration_kind_symbol)            \
+  V(array_iterator_next_symbol)             \
+  V(array_iterator_object_symbol)           \
+  V(call_site_function_symbol)              \
+  V(call_site_position_symbol)              \
+  V(call_site_receiver_symbol)              \
+  V(call_site_strict_symbol)                \
+  V(class_end_position_symbol)              \
+  V(class_start_position_symbol)            \
+  V(detailed_stack_trace_symbol)            \
+  V(elements_transition_symbol)             \
+  V(error_end_pos_symbol)                   \
+  V(error_script_symbol)                    \
+  V(error_start_pos_symbol)                 \
+  V(formatted_stack_trace_symbol)           \
+  V(frozen_symbol)                          \
+  V(hash_code_symbol)                       \
+  V(home_object_symbol)                     \
+  V(internal_error_symbol)                  \
+  V(intl_impl_object_symbol)                \
+  V(intl_initialized_marker_symbol)         \
+  V(megamorphic_symbol)                     \
+  V(nonexistent_symbol)                     \
+  V(nonextensible_symbol)                   \
+  V(normal_ic_symbol)                       \
+  V(observed_symbol)                        \
+  V(premonomorphic_symbol)                  \
+  V(promise_debug_marker_symbol)            \
+  V(promise_has_handler_symbol)             \
+  V(promise_on_resolve_symbol)              \
+  V(promise_on_reject_symbol)               \
+  V(promise_raw_symbol)                     \
+  V(promise_status_symbol)                  \
+  V(promise_value_symbol)                   \
+  V(sealed_symbol)                          \
+  V(stack_trace_symbol)                     \
+  V(string_iterator_iterated_string_symbol) \
+  V(string_iterator_next_index_symbol)      \
+  V(uninitialized_symbol)
+
 
 #define PUBLIC_SYMBOL_LIST(V)                                    \
   V(has_instance_symbol, symbolHasInstance, Symbol.hasInstance)  \
   V(is_concat_spreadable_symbol, symbolIsConcatSpreadable,       \
     Symbol.isConcatSpreadable)                                   \
   V(is_regexp_symbol, symbolIsRegExp, Symbol.isRegExp)           \
   V(iterator_symbol, symbolIterator, Symbol.iterator)            \
   V(to_string_tag_symbol, symbolToStringTag, Symbol.toStringTag) \
   V(unscopables_symbol, symbolUnscopables, Symbol.unscopables)
 
@@ skipping 1476 matching lines @@
   };
 
   static const StringTypeTable string_type_table[];
   static const ConstantStringTable constant_string_table[];
   static const StructTable struct_table[];
 
   // The special hidden string which is an empty string, but does not match
   // any string when looked up in properties.
   String* hidden_string_;
 
-  void AddPrivateGlobalSymbols(Handle<Object> private_intern_table);
-
   struct GCCallbackPair {
     GCCallbackPair(v8::Isolate::GCCallback callback, GCType gc_type,
                    bool pass_isolate)
         : callback(callback), gc_type(gc_type), pass_isolate(pass_isolate) {}
 
     bool operator==(const GCCallbackPair& other) const {
       return other.callback == callback;
     }
 
     v8::Isolate::GCCallback callback;
@@ skipping 876 matching lines @@
   DisallowHeapAllocation no_allocation;  // i.e. no gc allowed.
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(PathTracer);
 };
 #endif  // DEBUG
 }
 }  // namespace v8::internal
 
 #endif  // V8_HEAP_HEAP_H_