Unify symbols sharing across native scripts and runtime.

src/array-iterator.js

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var $arrayValues;
 
 (function(global, utils) {
 
 "use strict";
 
 %CheckIsBootstrapping();
 
+// -----------------------------------------------------------------------
+// Imports
+
+var ArrayIterationKindSymbol =

[rossberg, 2015/08/20 12:50:12]

I don't feel too strongly, but don't we typically use capitalised names for
functions only?

+    utils.GetPrivateSymbol("array_iteration_kind_symbol");
+var ArrayIteratorNextIndexSymbol =
+    utils.GetPrivateSymbol("array_iterator_next_symbol");
+var ArrayIteratorObjectSymbol =
+    utils.GetPrivateSymbol("array_iterator_object_symbol");
 var GlobalArray = global.Array;
 
 macro TYPED_ARRAYS(FUNCTION)
   FUNCTION(Uint8Array)
   FUNCTION(Int8Array)
   FUNCTION(Uint16Array)
   FUNCTION(Int16Array)
   FUNCTION(Uint32Array)
   FUNCTION(Int32Array)
   FUNCTION(Float32Array)
   FUNCTION(Float64Array)
   FUNCTION(Uint8ClampedArray)
 endmacro
 
 macro COPY_FROM_GLOBAL(NAME)
   var GlobalNAME = global.NAME;
 endmacro
 
 TYPED_ARRAYS(COPY_FROM_GLOBAL)
 
-var arrayIteratorObjectSymbol = GLOBAL_PRIVATE("ArrayIterator#object");
-var arrayIteratorNextIndexSymbol = GLOBAL_PRIVATE("ArrayIterator#next");
-var arrayIterationKindSymbol = GLOBAL_PRIVATE("ArrayIterator#kind");
-
+// -----------------------------------------------------------------------
 
 function ArrayIterator() {}
 
 
 // TODO(wingo): Update section numbers when ES6 has stabilized.  The
 // section numbers below are already out of date as of the May 2014
 // draft.
 
 
 // 15.4.5.1 CreateArrayIterator Abstract Operation
 function CreateArrayIterator(array, kind) {
   var object = TO_OBJECT(array);
   var iterator = new ArrayIterator;
-  SET_PRIVATE(iterator, arrayIteratorObjectSymbol, object);
-  SET_PRIVATE(iterator, arrayIteratorNextIndexSymbol, 0);
-  SET_PRIVATE(iterator, arrayIterationKindSymbol, kind);
+  SET_PRIVATE(iterator, ArrayIteratorObjectSymbol, object);
+  SET_PRIVATE(iterator, ArrayIteratorNextIndexSymbol, 0);
+  SET_PRIVATE(iterator, ArrayIterationKindSymbol, kind);
   return iterator;
 }
 
 
 // 15.19.4.3.4 CreateItrResultObject
 function CreateIteratorResultObject(value, done) {
   return {value: value, done: done};
 }
 
 
 // 22.1.5.2.2 %ArrayIteratorPrototype%[@@iterator]
 function ArrayIteratorIterator() {
     return this;
 }
 
 
 // 15.4.5.2.2 ArrayIterator.prototype.next( )
 function ArrayIteratorNext() {
   var iterator = TO_OBJECT(this);
 
-  if (!HAS_DEFINED_PRIVATE(iterator, arrayIteratorNextIndexSymbol)) {
+  if (!HAS_DEFINED_PRIVATE(iterator, ArrayIteratorNextIndexSymbol)) {
     throw MakeTypeError(kIncompatibleMethodReceiver,
                         'Array Iterator.prototype.next', this);
   }
 
-  var array = GET_PRIVATE(iterator, arrayIteratorObjectSymbol);
+  var array = GET_PRIVATE(iterator, ArrayIteratorObjectSymbol);
   if (IS_UNDEFINED(array)) {
     return CreateIteratorResultObject(UNDEFINED, true);
   }
 
-  var index = GET_PRIVATE(iterator, arrayIteratorNextIndexSymbol);
-  var itemKind = GET_PRIVATE(iterator, arrayIterationKindSymbol);
+  var index = GET_PRIVATE(iterator, ArrayIteratorNextIndexSymbol);
+  var itemKind = GET_PRIVATE(iterator, ArrayIterationKindSymbol);
   var length = TO_UINT32(array.length);
 
   // "sparse" is never used.
 
   if (index >= length) {
-    SET_PRIVATE(iterator, arrayIteratorObjectSymbol, UNDEFINED);
+    SET_PRIVATE(iterator, ArrayIteratorObjectSymbol, UNDEFINED);
     return CreateIteratorResultObject(UNDEFINED, true);
   }
 
-  SET_PRIVATE(iterator, arrayIteratorNextIndexSymbol, index + 1);
+  SET_PRIVATE(iterator, ArrayIteratorNextIndexSymbol, index + 1);
 
   if (itemKind == ITERATOR_KIND_VALUES) {
     return CreateIteratorResultObject(array[index], false);
   }
 
   if (itemKind == ITERATOR_KIND_ENTRIES) {
     return CreateIteratorResultObject([index, array[index]], false);
   }
 
   return CreateIteratorResultObject(index, false);
@@ skipping 57 matching lines @@
   to.ArrayIteratorCreateResultObject = CreateIteratorResultObject;
 });
 
 $arrayValues = ArrayValues;
 
 utils.ExportToRuntime(function(to) {
   to.ArrayValues = ArrayValues;
 });
 
 })