Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1293493003: Do not export natives to runtime via js builtins object. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not export natives to runtime via js builtins object. Using a temporary container object instead. R=jkummerow@chromium.org Committed: https://crrev.com/aa4ad8ca64c71d21972c45d951d3f02f1e72a993 Cr-Commit-Position: refs/heads/master@{#30175}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -147 lines) Patch
M src/array-iterator.js View 1 chunk +4 lines, -0 lines 0 comments Download
M src/bootstrapper.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 6 chunks +82 lines, -90 lines 0 comments Download
M src/collection.js View 4 chunks +18 lines, -18 lines 0 comments Download
M src/date.js View 1 chunk +3 lines, -2 lines 0 comments Download
M src/messages.js View 2 chunks +4 lines, -1 line 0 comments Download
M src/object-observe.js View 2 chunks +11 lines, -8 lines 0 comments Download
M src/prologue.js View 6 chunks +30 lines, -1 line 0 comments Download
M src/promise.js View 2 chunks +11 lines, -12 lines 0 comments Download
M src/proxy.js View 2 chunks +7 lines, -10 lines 0 comments Download
M src/runtime.js View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/v8natives.js View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 4 months ago (2015-08-14 12:01:14 UTC) #1
Jakob Kummerow
lgtm
5 years, 4 months ago (2015-08-14 12:08:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293493003/1
5 years, 4 months ago (2015-08-14 12:09:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-14 12:34:52 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 12:35:06 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/aa4ad8ca64c71d21972c45d951d3f02f1e72a993
Cr-Commit-Position: refs/heads/master@{#30175}

Powered by Google App Engine
This is Rietveld 408576698