Issue 1293453002: Add more OWNERS for components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1293453002: Add more OWNERS for components. (Closed)

Created:
5 years, 4 months ago by Benedikt Meurer

Modified:
5 years, 4 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Add more OWNERS for components. R=yangguo@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/2c5b69d85124021a39849d98960a39bdf1cece47

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -0 lines)			Patch
M	src/debug/OWNERS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/full-codegen/OWNERS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/heap/OWNERS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ic/OWNERS	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

Hey Yang, As discussed offline. Please take a look. Thanks, Benedikt

5 years, 4 months ago (2015-08-13 07:34:48 UTC) #2

Yang

On 2015/08/13 07:34:48, Benedikt Meurer wrote: > Hey Yang, > > As discussed offline. > ...

5 years, 4 months ago (2015-08-13 07:35:05 UTC) #3

Benedikt Meurer

Committed patchset #1 (id:1) manually as 2c5b69d85124021a39849d98960a39bdf1cece47.

5 years, 4 months ago (2015-08-13 07:35:46 UTC) #4

Hannes Payer (out of office)

On 2015/08/13 07:35:46, Benedikt Meurer wrote: > Committed patchset #1 (id:1) manually as > 2c5b69d85124021a39849d98960a39bdf1cece47. ...

5 years, 4 months ago (2015-08-13 07:46:04 UTC) #5

Benedikt Meurer

5 years, 4 months ago (2015-08-13 07:56:43 UTC) #6

Message was sent while issue was closed.

On 2015/08/13 07:46:04, Hannes Payer wrote:
> On 2015/08/13 07:35:46, Benedikt Meurer wrote:
> > Committed patchset #1 (id:1) manually as
> > 2c5b69d85124021a39849d98960a39bdf1cece47.
> 
> The idea of owner files is getting owner reviews, so that failed already on
that
> level.

Ok.

Expand Messages | Collapse Messages