Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1293393003: Componentize gcm_account_tracker (Closed)

Created:
5 years, 4 months ago by Jitu( very slow this week)
Modified:
5 years, 4 months ago
Reviewers:
droger, vivekg, fgorski
CC:
chromium-reviews, zea+watch_chromium.org, Nicolas Zea
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize gcm_account_tracker. Moved chrome/browser/services/gcm/gcm_account_tracker.* and its related UT file to components/gcm_driver/ BUG=519563 Committed: https://crrev.com/70c5b4cf612a429742c06b6fabaa521b38bc44fc Cr-Commit-Position: refs/heads/master@{#344288}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1070 lines) Patch
D chrome/browser/services/gcm/gcm_account_tracker.h View 1 chunk +0 lines, -165 lines 0 comments Download
D chrome/browser/services/gcm/gcm_account_tracker.cc View 1 chunk +0 lines, -376 lines 0 comments Download
D chrome/browser/services/gcm/gcm_account_tracker_unittest.cc View 1 chunk +0 lines, -520 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/gcm_driver.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/gcm_driver/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A + components/gcm_driver/gcm_account_tracker.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/gcm_driver/gcm_account_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/gcm_driver/gcm_account_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Jitu( very slow this week)
PTAL...
5 years, 4 months ago (2015-08-18 14:11:12 UTC) #2
droger
Nice work, LGTM.
5 years, 4 months ago (2015-08-18 14:14:01 UTC) #3
Jitu( very slow this week)
Dear fgorski, Please do the OWNER review for below files -- chrome/browser/services/gcm/* -- components/gcm_driver/*
5 years, 4 months ago (2015-08-19 05:05:31 UTC) #5
droger
CC zea too who is currently involved on iOS-related componentization.
5 years, 4 months ago (2015-08-19 11:12:24 UTC) #6
fgorski
lgtm
5 years, 4 months ago (2015-08-19 16:13:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293393003/1
5 years, 4 months ago (2015-08-19 16:52:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-19 18:53:42 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 18:54:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70c5b4cf612a429742c06b6fabaa521b38bc44fc
Cr-Commit-Position: refs/heads/master@{#344288}

Powered by Google App Engine
This is Rietveld 408576698