Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 1293393002: Remove a bunch of dead JBIG2 code. (Closed)

Created:
5 years, 4 months ago by Lei Zhang
Modified:
5 years, 4 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -828 lines) Patch
M core/src/fxcodec/jbig2/JBig2_GeneralDecoder.h View 1 6 chunks +26 lines, -45 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_GeneralDecoder.cpp View 4 chunks +10 lines, -783 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Lei Zhang
5 years, 4 months ago (2015-08-18 20:14:14 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1293393002/diff/1/core/src/fxcodec/jbig2/JBig2_GeneralDecoder.h File core/src/fxcodec/jbig2/JBig2_GeneralDecoder.h (right): https://codereview.chromium.org/1293393002/diff/1/core/src/fxcodec/jbig2/JBig2_GeneralDecoder.h#newcode21 core/src/fxcodec/jbig2/JBig2_GeneralDecoder.h:21: typedef enum { nit: enum JBig2Corner {
5 years, 4 months ago (2015-08-18 20:23:20 UTC) #3
Lei Zhang
https://codereview.chromium.org/1293393002/diff/1/core/src/fxcodec/jbig2/JBig2_GeneralDecoder.h File core/src/fxcodec/jbig2/JBig2_GeneralDecoder.h (right): https://codereview.chromium.org/1293393002/diff/1/core/src/fxcodec/jbig2/JBig2_GeneralDecoder.h#newcode21 core/src/fxcodec/jbig2/JBig2_GeneralDecoder.h:21: typedef enum { On 2015/08/18 20:23:20, Tom Sepez (Out ...
5 years, 4 months ago (2015-08-20 21:35:48 UTC) #4
Lei Zhang
5 years, 4 months ago (2015-08-20 21:36:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7830e9e38d4155335b7287f8edb2b3a6cece5b01 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698