Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1293293002: Attach type info to extension method and object method tear-offs (Closed)

Created:
5 years, 4 months ago by Leaf
Modified:
5 years, 4 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Attach type info to extension method and object method tear-offs Fixes #189. BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/07b9ee02dee50706cf6c9d25e4ae475564767749

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -222 lines) Patch
M lib/runtime/_classes.js View 1 1 chunk +3 lines, -0 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M test/browser/runtime_tests.js View 1 1 chunk +10 lines, -0 lines 0 comments Download
M test/codegen/expect/js_test.txt View 1 1 chunk +220 lines, -220 lines 0 comments Download
M test/codegen/expect/methods.js View 1 chunk +4 lines, -0 lines 0 comments Download
M test/codegen/methods.dart View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Leaf
5 years, 4 months ago (2015-08-18 00:18:04 UTC) #2
Jennifer Messerly
lgtm
5 years, 4 months ago (2015-08-18 19:14:56 UTC) #3
Leaf
5 years, 4 months ago (2015-08-19 17:01:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
07b9ee02dee50706cf6c9d25e4ae475564767749 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698