[heap,cctest] Get rid of protected-for-sake-of-testing scope.

[heap,cctest] Get rid of protected-for-sake-of-testing scope.

BUG=

Committed: https://crrev.com/477f5a81f0183e6c175c2327286b541267912354
Cr-Commit-Position: refs/heads/master@{#30301}

[Michael Lippautz, 2015-08-21 11:01:54]

mlippautz@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Lippautz, 2015-08-21 11:01:54]

WDYT? Was actually more invasive than I thought it would be.

[Michael Starzinger, 2015-08-21 11:14:10]

I like the fact that the heap.h interface is clear of the protected section, +1
on that. As for the cctest structure, I don't have a strong opinion. I would be
fine with it, Benedikt might have a strong opinion on that.

https://codereview.chromium.org/1293283003/diff/20001/test/cctest/test-heap.h
File test/cctest/test-heap.h (right):

https://codereview.chromium.org/1293283003/diff/20001/test/cctest/test-heap.h...
test/cctest/test-heap.h:5: #ifndef TEST_HEAP_H_
The name of this file is misleading, it looks like this header is specific to
test-heap.cc when it is actually the thing providing the HeapTester class. Can
we either move all of this into cctest.h or call this file heap-tester.h
instead?

[Michael Starzinger, 2015-08-21 11:14:10]

I like the fact that the heap.h interface is clear of the protected section, +1
on that. As for the cctest structure, I don't have a strong opinion. I would be
fine with it, Benedikt might have a strong opinion on that.

https://codereview.chromium.org/1293283003/diff/20001/test/cctest/test-heap.h
File test/cctest/test-heap.h (right):

https://codereview.chromium.org/1293283003/diff/20001/test/cctest/test-heap.h...
test/cctest/test-heap.h:5: #ifndef TEST_HEAP_H_
The name of this file is misleading, it looks like this header is specific to
test-heap.cc when it is actually the thing providing the HeapTester class. Can
we either move all of this into cctest.h or call this file heap-tester.h
instead?

[Michael Lippautz, 2015-08-21 11:18:48]

mlippautz@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Michael Lippautz, 2015-08-21 11:18:48]

+benedikt

(I would like to have a look at gtest "later" but get rid of the HeapTester
now.)

[Benedikt Meurer, 2015-08-21 11:28:09]

LGTM.

[Michael Starzinger, 2015-08-21 11:56:32]

LGTM.

https://codereview.chromium.org/1293283003/diff/40001/test/cctest/heap-tester.h
File test/cctest/heap-tester.h (right):

https://codereview.chromium.org/1293283003/diff/40001/test/cctest/heap-tester...
test/cctest/heap-tester.h:5: #ifndef HEAP_TESTER_H_
Let's also add the file to the cctest.gyp sources.

[Michael Lippautz, 2015-08-21 12:15:10]

Thanks!

https://codereview.chromium.org/1293283003/diff/40001/test/cctest/heap-tester.h
File test/cctest/heap-tester.h (right):

https://codereview.chromium.org/1293283003/diff/40001/test/cctest/heap-tester...
test/cctest/heap-tester.h:5: #ifndef HEAP_TESTER_H_
On 2015/08/21 11:56:32, Michael Starzinger wrote:
> Let's also add the file to the cctest.gyp sources.

Done.

[Michael Lippautz, 2015-08-21 12:15:14]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2015-08-21 12:15:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1293283003/#ps60001
(title: "Add heap-tester.h to cctest.gyp")

[commit-bot: I haz the power, 2015-08-21 12:15:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1293283003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1293283003/60001

[commit-bot: I haz the power, 2015-08-21 12:40:27]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-08-21 12:40:45]

Patchset 4 (id:??) landed as
https://crrev.com/477f5a81f0183e6c175c2327286b541267912354
Cr-Commit-Position: refs/heads/master@{#30301}