Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1293273005: Add presubmit check for header inclusion violation. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add presubmit check for header inclusion violation. This warns about include directives of inline headers within normal header files. Note that this warning should not close the tree or prevent the CQ from landing the patch. R=jkummerow@chromium.org Committed: https://crrev.com/ee4a639681931a3b90ebd08371be26d7f749e78d Cr-Commit-Position: refs/heads/master@{#30228}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M PRESUBMIT.py View 1 2 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-18 14:24:35 UTC) #2
Jakob Kummerow
lgtm https://codereview.chromium.org/1293273005/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/1293273005/diff/1/PRESUBMIT.py#newcode145 PRESUBMIT.py:145: """Attempts to prevent inclusion in inline headers into ...
5 years, 4 months ago (2015-08-18 16:02:55 UTC) #3
Michael Starzinger
Addressed. Thanks! Landing. https://codereview.chromium.org/1293273005/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/1293273005/diff/1/PRESUBMIT.py#newcode145 PRESUBMIT.py:145: """Attempts to prevent inclusion in inline ...
5 years, 4 months ago (2015-08-18 16:04:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293273005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293273005/20001
5 years, 4 months ago (2015-08-18 16:19:47 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-18 16:41:07 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 16:41:24 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ee4a639681931a3b90ebd08371be26d7f749e78d
Cr-Commit-Position: refs/heads/master@{#30228}

Powered by Google App Engine
This is Rietveld 408576698