Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1378)

Unified Diff: Source/devtools/front_end/timeline/TimelineModel.js

Issue 1293273002: DevTools: Use better event titles on timeline tree view. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineModel.js
diff --git a/Source/devtools/front_end/timeline/TimelineModel.js b/Source/devtools/front_end/timeline/TimelineModel.js
index d2426980a7a5e8b964534e5b278ef4acd5cfdc98..cf178d7e4af756b25271d293916253f9ae3ed376 100644
--- a/Source/devtools/front_end/timeline/TimelineModel.js
+++ b/Source/devtools/front_end/timeline/TimelineModel.js
@@ -1511,7 +1511,6 @@ WebInspector.TimelineModel.buildTopDownTree = function(events, startTime, endTim
node.totalTime = time;
node.selfTime = time;
node.parent = parent;
- node.name = eventName(e);
node.id = id;
node.event = e;
parent.children.set(id, node);
@@ -1534,19 +1533,6 @@ WebInspector.TimelineModel.buildTopDownTree = function(events, startTime, endTim
parent = parent.parent;
}
- /**
- * @param {!WebInspector.TracingModel.Event} e
- * @return {string}
- */
- function eventName(e)
- {
- if (e.name === "JSFrame")
- return WebInspector.beautifyFunctionName(e.args.data.functionName);
- if (e.name === "EventDispatch")
- return WebInspector.UIString("Event%s", e.args.data ? " (" + e.args.data.type + ")" : "");
- return e.name;
- }
-
WebInspector.TimelineModel.forEachEvent(events, onStartEvent, onEndEvent);
root.totalTime -= root.selfTime;
root.selfTime = 0;

Powered by Google App Engine
This is Rietveld 408576698