Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1293273002: DevTools: Use better event titles on timeline tree view. (Closed)

Created:
5 years, 4 months ago by alph
Modified:
5 years, 4 months ago
Reviewers:
caseq
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: Use better event titles on timeline tree view. BUG=521215 R=caseq Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200760

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressing comment #

Patch Set 3 : update the test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -34 lines) Patch
M LayoutTests/inspector/tracing/timeline-js-callstacks.html View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M LayoutTests/inspector/tracing/timeline-js-callstacks-expected.txt View 1 2 2 chunks +14 lines, -14 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineModel.js View 2 chunks +0 lines, -14 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineTreeView.js View 1 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
alph
5 years, 4 months ago (2015-08-17 21:51:59 UTC) #1
caseq
lgtm https://codereview.chromium.org/1293273002/diff/1/Source/devtools/front_end/timeline/TimelineTreeView.js File Source/devtools/front_end/timeline/TimelineTreeView.js (right): https://codereview.chromium.org/1293273002/diff/1/Source/devtools/front_end/timeline/TimelineTreeView.js#newcode361 Source/devtools/front_end/timeline/TimelineTreeView.js:361: function eventName(e) inline?
5 years, 4 months ago (2015-08-17 22:05:36 UTC) #2
alph
ptal
5 years, 4 months ago (2015-08-17 22:30:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293273002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293273002/40001
5 years, 4 months ago (2015-08-17 22:39:57 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/57600) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-08-17 22:41:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293273002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293273002/40001
5 years, 4 months ago (2015-08-18 06:33:53 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/57756) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-08-18 06:35:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293273002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293273002/40001
5 years, 4 months ago (2015-08-18 20:16:55 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/58069) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-08-18 20:19:21 UTC) #19
alph
https://codereview.chromium.org/1293273002/diff/1/Source/devtools/front_end/timeline/TimelineTreeView.js File Source/devtools/front_end/timeline/TimelineTreeView.js (right): https://codereview.chromium.org/1293273002/diff/1/Source/devtools/front_end/timeline/TimelineTreeView.js#newcode361 Source/devtools/front_end/timeline/TimelineTreeView.js:361: function eventName(e) On 2015/08/17 22:05:36, caseq wrote: > inline? ...
5 years, 4 months ago (2015-08-18 21:03:23 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293273002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293273002/40001
5 years, 4 months ago (2015-08-18 21:04:21 UTC) #22
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 22:34:28 UTC) #23
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200760

Powered by Google App Engine
This is Rietveld 408576698