Completely remove InterruptableThreadState and Fix ThreadRegistry leak

runtime/vm/thread_registry.cc

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/thread_registry.h"
 
 #include "vm/isolate.h"
 #include "vm/lockers.h"
 
 namespace dart {
@@ skipping 49 matching lines @@
 
 
 void ThreadRegistry::ResumeAllThreads() {
   MonitorLocker ml(monitor_);
   ASSERT(in_rendezvous_);
   in_rendezvous_ = false;
   ml.NotifyAll();
 }
 
 
+void ThreadRegistry::PruneThread(Thread* thread) {
+  MonitorLocker ml(monitor_);
+  intptr_t length = entries_.length();
+  if (length == 0) {
+    return;
+  }
+  intptr_t found_index = -1;
+  for (intptr_t index = 0; index < length; index++) {
+    if (entries_.At(index).thread == thread) {
+      found_index = index;
+      break;
+    }
+  }
+  if (found_index < 0) {
+    return;
+  }
+  if (found_index != (length - 1)) {
+    // Swap with last entry.
+    entries_.Swap(found_index, length - 1);
+  }
+  entries_.RemoveLast();
+}
+
+
+ThreadRegistry::EntryIterator::EntryIterator(ThreadRegistry* registry)
+    : index_(0),
+      registry_(NULL) {
+  Reset(registry);

[koda, 2015/08/20 15:45:14]

Wouldn't it be simpler to have a MonitorLocker field in EntryIterator and
initialize it with registry->monitor_ in the initializer list? (You don't
actually reuse the iterator anywhere.)

[Cutch, 2015/08/20 20:40:19]

Acknowledged.

+}
+
+
+ThreadRegistry::EntryIterator::~EntryIterator() {
+  Reset(NULL);
+}
+
+
+void ThreadRegistry::EntryIterator::Reset(ThreadRegistry* registry) {

[Ivan Posva, 2015/08/20 18:00:10]

Personally I find resettable iterators confusing to use as it becomes entirely
unclear what data structure you are iterating over. Especially since it can be
Reset at any time.

[Cutch, 2015/08/20 20:40:19]

Reset is now private.

+  // Reset index.
+  index_ = 0;
+
+  // Unlock old registry.
+  if (registry_ != NULL) {
+    registry_->monitor_->Exit();
+  }
+
+  registry_ = registry;
+
+  // Lock new registry.
+  if (registry_ != NULL) {
+    registry_->monitor_->Enter();
+  }
+}
+
+
+bool ThreadRegistry::EntryIterator::HasNext() const {
+  if (registry_ == NULL) {
+    return false;
+  }
+  return index_ < registry_->entries_.length();
+}
+
+
+const ThreadRegistry::Entry& ThreadRegistry::EntryIterator::Next() {
+  ASSERT(HasNext());
+  return registry_->entries_.At(index_++);
+}
+
+
 void ThreadRegistry::CheckSafepointLocked() {
   int64_t last_round = -1;
   while (in_rendezvous_) {
     ASSERT(round_ >= last_round);
     if (round_ != last_round) {
       ASSERT((last_round == -1) || (round_ == (last_round + 1)));
       last_round = round_;
       // Participate in this round.
       // TODO(koda): Rename Thread::PrepareForGC and call it here?
       if (--remaining_ == 0) {
@@ skipping 18 matching lines @@
   for (int i = 0; i < entries_.length(); ++i) {
     const Entry& entry = entries_[i];
     if (entry.scheduled) {
       ++count;
     }
   }
   return count;
 }
 
 }  // namespace dart