Completely remove InterruptableThreadState and Fix ThreadRegistry leak

runtime/vm/profiler.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/address_sanitizer.h"
 #include "platform/memory_sanitizer.h"
 #include "platform/utils.h"
 
 #include "vm/allocation.h"
 #include "vm/atomic.h"
@@ skipping 151 matching lines @@
     return;
   }
   if (!FLAG_profile) {
     return;
   }
   ASSERT(initialized_);
   IsolateProfilerData* profiler_data = isolate->profiler_data();
   if (profiler_data == NULL) {
     return;
   }
-  ThreadInterrupter::Register(RecordSampleInterruptCallback, isolate);
+  Thread* thread = Thread::Current();
+  thread->SetThreadInterrupter(RecordSampleInterruptCallback, isolate);

[Ivan Posva, 2015/08/20 18:00:10]

How often does the first value change while a process is running?

[Cutch, 2015/08/20 20:40:18]

Aside from tests it never changes.

   ThreadInterrupter::WakeUp();
 }
 
 
 void Profiler::EndExecution(Isolate* isolate) {
   if (isolate == NULL) {
     return;
   }
   if (!FLAG_profile) {
     return;
   }
   ASSERT(initialized_);
-  ThreadInterrupter::Unregister();
+  Thread* thread = Thread::Current();
+  thread->SetThreadInterrupter(NULL, NULL);
 }
 
 
 IsolateProfilerData::IsolateProfilerData(SampleBuffer* sample_buffer,
                                          bool own_sample_buffer) {
   ASSERT(sample_buffer != NULL);
   sample_buffer_ = sample_buffer;
   own_sample_buffer_ = own_sample_buffer;
   block_count_ = 0;
 }
@@ skipping 1123 matching lines @@
                                                uword pc) {
   return vm_isolate->heap()->CodeContains(pc)
          || isolate->heap()->CodeContains(pc);
 }
 
 
 ProcessedSampleBuffer::ProcessedSampleBuffer() {
 }
 
 }  // namespace dart