Make it clear that base::FileDescriptor::auto_close is purely advisory.

Make it clear that base::FileDescriptor::auto_close is purely advisory.

close() the fd. Or don't.
I'm a sign, not a cop.

BUG=522207
Committed: https://crrev.com/33ee80f998c735246b5079c4614495493ad31307
Cr-Commit-Position: refs/heads/master@{#344178}

[dcheng, 2015-08-18 21:39:40]

dcheng@chromium.org changed reviewers:
+ thakis@chromium.org

[dcheng, 2015-08-18 21:39:40]

This was a fun surprise I came across today while doing an IPC review.

[Nico, 2015-08-18 22:32:30]

lgtm

https://codereview.chromium.org/1293153007/diff/1/base/file_descriptor_posix.h
File base/file_descriptor_posix.h (right):

https://codereview.chromium.org/1293153007/diff/1/base/file_descriptor_posix....
base/file_descriptor_posix.h:24: // other end, the receiver must make sure to
close() |fd| after its finished
s/its/it has/

https://codereview.chromium.org/1293153007/diff/1/base/file_descriptor_posix....
base/file_descriptor_posix.h:28: // TL;DR: I'm a sign, not a cop. Don't use this
class unless you absolutely have
remove this paragraph

[dcheng, 2015-08-18 23:30:14]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2015-08-18 23:30:14]

https://codereview.chromium.org/1293153007/diff/1/base/file_descriptor_posix.h
File base/file_descriptor_posix.h (right):

https://codereview.chromium.org/1293153007/diff/1/base/file_descriptor_posix....
base/file_descriptor_posix.h:24: // other end, the receiver must make sure to
close() |fd| after its finished
On 2015/08/18 at 22:32:30, Nico wrote:
> s/its/it has/

Done.

https://codereview.chromium.org/1293153007/diff/1/base/file_descriptor_posix....
base/file_descriptor_posix.h:28: // TL;DR: I'm a sign, not a cop. Don't use this
class unless you absolutely have
On 2015/08/18 at 22:32:30, Nico wrote:
> remove this paragraph

Aww, I really wanted to find a legitimate way to use this phrase in Chrome =)

[dcheng, 2015-08-18 23:30:14]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1293153007/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2015-08-18 23:32:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1293153007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1293153007/20001

[commit-bot: I haz the power, 2015-08-19 01:37:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-19 01:37:18]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[dcheng, 2015-08-19 05:42:50]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2015-08-19 05:42:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1293153007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1293153007/20001

[commit-bot: I haz the power, 2015-08-19 08:37:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-19 08:38:28]

Patchset 2 (id:??) landed as
https://crrev.com/33ee80f998c735246b5079c4614495493ad31307
Cr-Commit-Position: refs/heads/master@{#344178}