Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 1293143002: [Android] Change battery_utils TieredSetCharging from exceptions based to discovery based (Closed)

Created:
5 years, 4 months ago by rnephew (Reviews Here)
Modified:
5 years, 4 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Change battery_utils TieredSetCharging from exceptions based to discovery based Currently, it throws an exception to know it cannot do hardware level disable, this changes it to use profile discovery to decide how to disable charging. BUG=520958 Committed: https://crrev.com/c0202d6ab7d128fe54e6fea8ab654918e5e2f3f2 Cr-Commit-Position: refs/heads/master@{#343929}

Patch Set 1 #

Total comments: 2

Patch Set 2 : logging #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M build/android/pylib/device/battery_utils.py View 1 1 chunk +9 lines, -8 lines 0 comments Download
M build/android/pylib/device/battery_utils_test.py View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
rnephew (Reviews Here)
5 years, 4 months ago (2015-08-17 16:00:54 UTC) #2
perezju
lgtm w/nit https://codereview.chromium.org/1293143002/diff/1/build/android/pylib/device/battery_utils.py File build/android/pylib/device/battery_utils.py (right): https://codereview.chromium.org/1293143002/diff/1/build/android/pylib/device/battery_utils.py#newcode494 build/android/pylib/device/battery_utils.py:494: else: nit: maybe keep a logging.info to ...
5 years, 4 months ago (2015-08-18 09:14:15 UTC) #3
rnephew (Wrong account)
https://codereview.chromium.org/1293143002/diff/1/build/android/pylib/device/battery_utils.py File build/android/pylib/device/battery_utils.py (right): https://codereview.chromium.org/1293143002/diff/1/build/android/pylib/device/battery_utils.py#newcode494 build/android/pylib/device/battery_utils.py:494: else: On 2015/08/18 09:14:15, perezju wrote: > nit: maybe ...
5 years, 4 months ago (2015-08-18 14:54:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293143002/20001
5 years, 4 months ago (2015-08-18 14:55:29 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-18 15:58:06 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 15:58:56 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c0202d6ab7d128fe54e6fea8ab654918e5e2f3f2
Cr-Commit-Position: refs/heads/master@{#343929}

Powered by Google App Engine
This is Rietveld 408576698