Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3677)

Unified Diff: chrome/browser/metrics/variations/variations_service.h

Issue 1293113004: Introduce (Chrome)VariationsServiceClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Self-review Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/variations/variations_service.h
diff --git a/chrome/browser/metrics/variations/variations_service.h b/chrome/browser/metrics/variations/variations_service.h
index f96f31e45a9e9a0b4fa512d100c477a478f6762f..4bcf7c25becbb35abb11cc257f1ca0571a4b55a6 100644
--- a/chrome/browser/metrics/variations/variations_service.h
+++ b/chrome/browser/metrics/variations/variations_service.h
@@ -18,6 +18,7 @@
#include "chrome/browser/metrics/variations/variations_request_scheduler.h"
#include "chrome/browser/metrics/variations/variations_seed_store.h"
#include "components/variations/variations_seed_simulator.h"
+#include "components/variations/variations_service_client.h"
#include "components/web_resource/resource_request_allowed_notifier.h"
#include "net/url_request/url_fetcher_delegate.h"
#include "url/gurl.h"
@@ -130,6 +131,7 @@ class VariationsService
// |state_manager|. Caller should ensure that |state_manager| is valid for the
// lifetime of this class.
static scoped_ptr<VariationsService> Create(
+ scoped_ptr<VariationsServiceClient> client,
PrefService* local_state,
metrics::MetricsStateManager* state_manager);
@@ -163,7 +165,8 @@ class VariationsService
// Does not take ownership of |state_manager|. Caller should ensure that
// |state_manager| is valid for the lifetime of this class. Use the |Create|
// factory method to create a VariationsService.
- VariationsService(web_resource::ResourceRequestAllowedNotifier* notifier,
+ VariationsService(scoped_ptr<VariationsServiceClient> client,
+ web_resource::ResourceRequestAllowedNotifier* notifier,
PrefService* local_state,
metrics::MetricsStateManager* state_manager);
@@ -224,6 +227,8 @@ class VariationsService
const base::Version& version,
const std::string& latest_country);
+ scoped_ptr<VariationsServiceClient> client_;
+
// The pref service used to store persist the variations seed.
PrefService* local_state_;

Powered by Google App Engine
This is Rietveld 408576698