Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Unified Diff: build/config/linux/gtk2/BUILD.gn

Issue 1293073006: Make gtk2/gtk3 compile time switchable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove deprecation warning. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/linux/gtk/BUILD.gn ('k') | build/config/linux/gtk3/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/linux/gtk2/BUILD.gn
diff --git a/build/config/linux/gtk/BUILD.gn b/build/config/linux/gtk2/BUILD.gn
similarity index 81%
copy from build/config/linux/gtk/BUILD.gn
copy to build/config/linux/gtk2/BUILD.gn
index 9c9c696fcf38394744e6f16bee09d66ca20d9a7d..e333e24eb51699516dc4bfa43b17adcee4ef91e2 100644
--- a/build/config/linux/gtk/BUILD.gn
+++ b/build/config/linux/gtk2/BUILD.gn
@@ -6,12 +6,12 @@ import("//build/config/linux/pkg_config.gni")
assert(is_linux, "This file should only be referenced on Linux")
-# Depend on //build/config/linux/gtk to use GTK.
+# Depend on //build/config/linux/gtk2 to use GTKv2.
#
# GN doesn't check visibility for configs so we give this an obviously internal
# name to discourage random targets from accidentally depending on this and
# bypassing the GTK target's visibility.
-pkg_config("gtk_internal_config") {
+pkg_config("gtk2_internal_config") {
# Gtk requires gmodule, but it does not list it as a dependency in some
# misconfigured systems.
packages = [
@@ -23,7 +23,7 @@ pkg_config("gtk_internal_config") {
# Basically no parts of Chrome should depend on GTK. To prevent accidents, the
# parts that explicitly need GTK are whitelisted on this target.
-group("gtk") {
+group("gtk2") {
visibility = [
"//chrome/browser/ui/libgtk2ui",
"//gpu/gles2_conform_support:gles2_conform_test_windowless",
@@ -31,15 +31,15 @@ group("gtk") {
"//remoting/host/it2me:remote_assistance_host",
"//remoting/host:remoting_me2me_host_static",
]
- public_configs = [ ":gtk_internal_config" ]
+ public_configs = [ ":gtk2_internal_config" ]
}
# Depend on "gtkprint" to get this.
-pkg_config("gtkprint_internal_config") {
+pkg_config("gtkprint2_internal_config") {
packages = [ "gtk+-unix-print-2.0" ]
}
-group("gtkprint") {
+group("gtkprint2") {
visibility = [ "//chrome/browser/ui/libgtk2ui" ]
- public_configs = [ ":gtkprint_internal_config" ]
+ public_configs = [ ":gtkprint2_internal_config" ]
}
« no previous file with comments | « build/config/linux/gtk/BUILD.gn ('k') | build/config/linux/gtk3/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698