Issue 1293033002: Fix -Wunused-function warnings on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1293033002: Fix -Wunused-function warnings on Windows. (Closed)

Created:
5 years, 4 months ago by Nico

Modified:
5 years, 4 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix -Wunused-function warnings on Windows. BUG=505316 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/38665a257c04d7f5300da83876650702a01eb397

Patch Set 1 #

Total comments: 2

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -7 lines)			Patch
	M	core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp	View		2 chunks	+4 lines, -0 lines	0 comments	Download
	M	core/src/fxge/win32/fx_win32_gdipext.cpp	View		1 chunk	+6 lines, -7 lines	2 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lei Zhang

lgtm https://codereview.chromium.org/1293033002/diff/1/core/src/fxge/win32/fx_win32_gdipext.cpp File core/src/fxge/win32/fx_win32_gdipext.cpp (left): https://codereview.chromium.org/1293033002/diff/1/core/src/fxge/win32/fx_win32_gdipext.cpp#oldcode25 core/src/fxge/win32/fx_win32_gdipext.cpp:25: return CombineModeIntersect; umm https://codereview.chromium.org/1293033002/diff/1/core/src/fxge/win32/fx_win32_gdipext.cpp#oldcode27 core/src/fxge/win32/fx_win32_gdipext.cpp:27: return CombineModeIntersect; ummmmmm

5 years, 4 months ago (2015-08-17 03:44:10 UTC) #3

Nico

5 years, 4 months ago (2015-08-17 04:17:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
38665a257c04d7f5300da83876650702a01eb397 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages