Issue 129303003: Revert of Revert of chromeos: Don't send empty power management policies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 129303003: Revert of Revert of chromeos: Don't send empty power management policies. (Closed)

Created:
6 years, 11 months ago by Noam Samuel

Modified:
6 years, 11 months ago

Reviewers:
bartfab (slow), benwells, Daniel Erat

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Created: 6 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+82 lines, -104 lines)			Patch
M	chrome/browser/apps/app_browsertest.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/policy/power_policy_browsertest.cc	View	4 chunks	+15 lines, -16 lines	0 comments	Download
M	chrome/browser/chromeos/power/power_prefs.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/chromeos/power/power_prefs_unittest.cc	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/system/automatic_reboot_manager_unittest.cc	View	6 chunks	+8 lines, -8 lines	0 comments	Download
M	chromeos/dbus/fake_power_manager_client.h	View	3 chunks	+19 lines, -9 lines	0 comments	Download
M	chromeos/dbus/fake_power_manager_client.cc	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	chromeos/dbus/power_policy_controller.h	View	5 chunks	+2 lines, -15 lines	0 comments	Download
M	chromeos/dbus/power_policy_controller.cc	View	4 chunks	+6 lines, -32 lines	0 comments	Download
M	chromeos/dbus/power_policy_controller_unittest.cc	View	8 chunks	+18 lines, -10 lines	0 comments	Download

Total messages: 4 (0 generated)

Noam Samuel

Created Revert of Revert of chromeos: Don't send empty power management policies.

6 years, 11 months ago (2014-01-08 22:08:14 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/129303003/1

6 years, 11 months ago (2014-01-08 22:13:25 UTC) #2

Message was sent while issue was closed.

lgtm

Thanks for re-landing this.