Issue 1293023003: Re-enable iframe load failure tests in fetch-request-redirect.html.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1293023003: Re-enable iframe load failure tests in fetch-request-redirect.html. (Closed)

Created:
5 years, 4 months ago by horo

Modified:
5 years, 4 months ago

Reviewers:
jsbell

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Re-enable iframe load failure tests in fetch-request-redirect.html. We can't detect the iframe load failure without timeout. So this CL adds timeout_enabled flag to iframe_test() and set it only for failure tests. BUG=522587 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200910

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -8 lines)			Patch
	M	LayoutTests/http/tests/serviceworker/fetch-request-redirect.html	View		2 chunks	+15 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293023003/1

5 years, 4 months ago (2015-08-20 16:40:28 UTC) #5

commit-bot: I haz the power

5 years, 4 months ago (2015-08-20 16:44:33 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200910

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages