Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Side by Side Diff: chrome/common/crash_keys.cc

Issue 1292983006: Componentize kBug464926CrashKey into crash_keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a TODO(mpearson) to cleanup once bug 464926 is fixed Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/crash_keys/crash_keys.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/crash_keys.h" 5 #include "chrome/common/crash_keys.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/format_macros.h" 8 #include "base/format_macros.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/strings/string_split.h" 10 #include "base/strings/string_split.h"
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 const char kSendAction[] = "sendaction"; 94 const char kSendAction[] = "sendaction";
95 95
96 } // namespace mac 96 } // namespace mac
97 #endif 97 #endif
98 98
99 #if defined(KASKO) 99 #if defined(KASKO)
100 const char kKaskoGuid[] = "kasko-guid"; 100 const char kKaskoGuid[] = "kasko-guid";
101 const char kKaskoEquivalentGuid[] = "kasko-equivalent-guid"; 101 const char kKaskoEquivalentGuid[] = "kasko-equivalent-guid";
102 #endif 102 #endif
103 103
104 // Used to help investigate bug 464926. NOTE: This value is defined multiple
105 // places in the codebase due to layering issues. DO NOT change the value here
106 // without changing it in all other places that it is defined in the codebase
107 // (search for |kBug464926CrashKey|).
108 const char kBug464926CrashKey[] = "bug-464926-info";
109
110 const char kViewCount[] = "view-count"; 104 const char kViewCount[] = "view-count";
111 105
112 size_t RegisterChromeCrashKeys() { 106 size_t RegisterChromeCrashKeys() {
113 // The following keys may be chunked by the underlying crash logging system, 107 // The following keys may be chunked by the underlying crash logging system,
114 // but ultimately constitute a single key-value pair. 108 // but ultimately constitute a single key-value pair.
115 base::debug::CrashKey fixed_keys[] = { 109 base::debug::CrashKey fixed_keys[] = {
116 #if defined(OS_MACOSX) 110 #if defined(OS_MACOSX)
117 { kMetricsClientId, kSmallSize }, 111 { kMetricsClientId, kSmallSize },
118 #else 112 #else
119 { kClientId, kSmallSize }, 113 { kClientId, kSmallSize },
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
362 } 356 }
363 357
364 ScopedPrinterInfo::~ScopedPrinterInfo() { 358 ScopedPrinterInfo::~ScopedPrinterInfo() {
365 for (size_t i = 0; i < kPrinterInfoCount; ++i) { 359 for (size_t i = 0; i < kPrinterInfoCount; ++i) {
366 std::string key = base::StringPrintf(kPrinterInfo, i + 1); 360 std::string key = base::StringPrintf(kPrinterInfo, i + 1);
367 base::debug::ClearCrashKey(key); 361 base::debug::ClearCrashKey(key);
368 } 362 }
369 } 363 }
370 364
371 } // namespace crash_keys 365 } // namespace crash_keys
OLDNEW
« no previous file with comments | « no previous file | components/crash_keys/crash_keys.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698