Componentize kBug464926CrashKey into crash_keys.

Componentize kBug464926CrashKey into crash_keys.

Move kBug464926CrashKey into //components/crash_keys/crash_keys.h
so that it can be shared between desktop and iOS and accessed from
omnibox component. Remove the comment about multiple definition as
the layering issue is resolved by this CL.

BUG=520968, 464926
Committed: https://crrev.com/a5b862fcdf31757fe4ea388cdc32bb41ccd66f89
Cr-Commit-Position: refs/heads/master@{#344723}

[sdefresne, 2015-08-20 19:46:27]

sdefresne@chromium.org changed reviewers:
+ justincohen@chromium.org, pkasting@chromium.org, rsesek@chromium.org

[sdefresne, 2015-08-20 19:46:27]

rsesek: please review
 - chrome/common/crash_keys.cc
 - components/crash_keys

pkasting: please review
 - components/omnibox

justincohen: please review
 - ios/chrome/browser/crash_report/crash_keys.cc

[justincohen, 2015-08-20 19:50:35]

https://codereview.chromium.org/1292983006/diff/1/ios/chrome/browser/crash_re...
File ios/chrome/browser/crash_report/crash_keys.cc (right):

https://codereview.chromium.org/1292983006/diff/1/ios/chrome/browser/crash_re...
ios/chrome/browser/crash_report/crash_keys.cc:24:
{crash_keys::kBug464926CrashKey, kSmallSize},
crash_keys::kSmallSize

[sdefresne, 2015-08-20 19:56:36]

https://codereview.chromium.org/1292983006/diff/1/ios/chrome/browser/crash_re...
File ios/chrome/browser/crash_report/crash_keys.cc (right):

https://codereview.chromium.org/1292983006/diff/1/ios/chrome/browser/crash_re...
ios/chrome/browser/crash_report/crash_keys.cc:24:
{crash_keys::kBug464926CrashKey, kSmallSize},
On 2015/08/20 at 19:50:34, justincohen wrote:
> crash_keys::kSmallSize

Thanks, fixed.

[Peter Kasting, 2015-08-20 19:57:02]

Can we just kill this instead?  It seems from reading the associated bug like
this is to gather any data for a crash we think is fixed.  That means if we can
verify no such crashes are coming in, we can remove this entirely.

Do you guys know how to look for dumps with a particular crash key on the crash
server?

[sdefresne, 2015-08-20 20:13:40]

Looking at the crash server, there are still crashes with that key reported with
M46, so I think we should probably keep the logging for some time yet.

+mpearson (as FYI) as he is the owner of the bug.

[Peter Kasting, 2015-08-20 20:22:15]

All right, LGTM for now, but if applicable, consider adding comments somewhere
like "if this is removed, the entire omnibox component dependency on crash_keys
can go away" or something.

[sdefresne, 2015-08-20 20:35:14]

On 2015/08/20 at 20:22:15, pkasting wrote:
> All right, LGTM for now, but if applicable, consider adding comments somewhere
like "if this is removed, the entire omnibox component dependency on crash_keys
can go away" or something.

Make sense. Done.

[Robert Sesek, 2015-08-20 22:32:01]

crash_keys LGTM

[sdefresne, 2015-08-21 07:45:31]

sdefresne@chromium.org changed reviewers:
+ droger@chromium.org
- justincohen@chromium.org

[sdefresne, 2015-08-21 07:45:32]

droger: can you review //ios/chrome/browser?

[droger, 2015-08-21 07:47:29]

lgtm

[sdefresne, 2015-08-21 07:56:51]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2015-08-21 07:56:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1292983006/#ps40001
(title: "Add a TODO(mpearson) to cleanup once bug 464926 is fixed")

[commit-bot: I haz the power, 2015-08-21 07:57:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1292983006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1292983006/40001

[commit-bot: I haz the power, 2015-08-21 08:40:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-21 08:40:45]

Patchset 3 (id:??) landed as
https://crrev.com/a5b862fcdf31757fe4ea388cdc32bb41ccd66f89
Cr-Commit-Position: refs/heads/master@{#344723}