Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Unified Diff: components/scheduler/child/idle_helper.h

Issue 1292983005: [scheduler]: Fix tracing issues with nested IdlePeriod trace events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add todo Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/scheduler/child/idle_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/scheduler/child/idle_helper.h
diff --git a/components/scheduler/child/idle_helper.h b/components/scheduler/child/idle_helper.h
index 5f8ca1e8ec1eaf4d0a9dee257704b1b020530cef..7b4f5c388aa2acc6ea99cd756de9f8ff4d26ad4d 100644
--- a/components/scheduler/child/idle_helper.h
+++ b/components/scheduler/child/idle_helper.h
@@ -146,11 +146,13 @@ class SCHEDULER_EXPORT IdleHelper
void TraceIdleIdleTaskStart();
void TraceIdleIdleTaskEnd();
- void TraceEventIdlePeriodStateChange(IdlePeriodState new_state,
- base::TimeTicks new_deadline,
- base::TimeTicks optional_now);
private:
+ void TraceEventIdlePeriodStateChange(IdlePeriodState new_state,
+ bool new_running_idle_task,
+ base::TraceTicks new_deadline,
+ base::TraceTicks optional_now);
+
SchedulerHelper* helper_; // NOT OWNED
Delegate* delegate_; // NOT OWNED
@@ -159,7 +161,8 @@ class SCHEDULER_EXPORT IdleHelper
base::TraceTicks idle_period_deadline_for_tracing_;
base::TraceTicks last_idle_task_trace_time_;
- bool nestable_events_started_;
+ bool idle_period_trace_event_started_;
+ bool running_idle_task_for_tracing_;
const char* tracing_category_;
const char* disabled_by_default_tracing_category_;
const char* idle_period_tracing_name_;
« no previous file with comments | « no previous file | components/scheduler/child/idle_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698