Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: build/config/BUILD.gn

Issue 1292983004: [GN]: Precompiled header support for GCC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/toolchain/mac/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILD.gn
diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn
index 488768d84f71fba10b8f55f9531f0827e5ba9c00..c41a536b08096a6024c04574522aad76d275444b 100644
--- a/build/config/BUILD.gn
+++ b/build/config/BUILD.gn
@@ -417,11 +417,10 @@ config("default_libs") {
# Add this config to your target to enable precompiled headers.
#
-# On Windows, precompiled headers are done on a per-target basis. If you have
-# just a couple of files, the time it takes to precompile (~2 seconds) can
-# actually be longer than the time saved. On a Z620, a 100 file target compiles
-# about 2 seconds faster with precompiled headers, with greater savings for
-# larger targets.
+# Precompiled headers are done on a per-target basis. If you have just a couple
+# of files, the time it takes to precompile (~2 seconds) can actually be longer
+# than the time saved. On a Z620, a 100 file target compiles about 2 seconds
+# faster with precompiled headers, with greater savings for larger targets.
#
# Recommend precompiled headers for targets with more than 50 .cc files.
config("precompiled_headers") {
@@ -449,5 +448,10 @@ config("precompiled_headers") {
# case but forgot the other one?). To reproduce this error, do a build,
# then delete the precompile.c.obj file, then build again.
cflags_c = [ "/wd4206" ]
+ } else if (is_mac && !is_official_build && !use_goma) {
+ # TODO:(andybons): enable this when GCC PCH support in the binary has been
+ # rolled.
+ #precompiled_header = "build/precompile.h"
+ #precompiled_source = "//build/precompile.h"
}
}
« no previous file with comments | « no previous file | build/toolchain/mac/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698