Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: tools/gn/ninja_binary_target_writer.h

Issue 1292983004: [GN]: Precompiled header support for GCC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: switch statement. error handling. some initial docs. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/ninja_binary_target_writer.h
diff --git a/tools/gn/ninja_binary_target_writer.h b/tools/gn/ninja_binary_target_writer.h
index 5888ac59bbac22c0ddda4788c2f12ca0adebc1e3..1a5e092e0cb183ae78f27c04f47b300c4464d844 100644
--- a/tools/gn/ninja_binary_target_writer.h
+++ b/tools/gn/ninja_binary_target_writer.h
@@ -55,15 +55,16 @@ class NinjaBinaryTargetWriter : public NinjaTargetWriter {
const OutputFile& input_dep,
std::vector<OutputFile>* object_files);
- // Writes a Windows .pch compile build line for a language type.
- void WriteWindowsPCHCommand(SubstitutionType flag_type,
- Toolchain::ToolType tool_type,
- const OutputFile& input_dep,
- std::vector<OutputFile>* object_files);
+ // Writes a .pch compile build line for a language type.
+ void WritePCHCommand(SubstitutionType flag_type,
+ Toolchain::ToolType tool_type,
+ Tool::PrecompiledHeaderType header_type,
+ const OutputFile& input_dep,
+ std::vector<OutputFile>* object_files);
// extra_deps are additional dependencies to run before the rule.
//
- // iorder_only_dep is the name of the stamp file that covers the dependencies
+ // order_only_dep is the name of the stamp file that covers the dependencies
// that must be run before doing any compiles.
//
// The files produced by the compiler will be added to two output vectors.

Powered by Google App Engine
This is Rietveld 408576698