Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1292983003: Add missing getTraceCategoryEnabledFlag() override. (Closed)

Created:
5 years, 4 months ago by sof
Modified:
5 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add missing getTraceCategoryEnabledFlag() override. For the Platform object used by ResourceTest, add required override of getTraceCategoryEnabledFlag(). Needed following the addition GC tracing in Blink r200146. R=haraken BUG=521230 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200606

Patch Set 1 #

Patch Set 2 : reorder methods for tidiness #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M Source/core/fetch/ResourceTest.cpp View 1 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look.
5 years, 4 months ago (2015-08-15 07:35:44 UTC) #2
haraken
LGTM
5 years, 4 months ago (2015-08-15 10:41:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292983003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292983003/20001
5 years, 4 months ago (2015-08-15 10:50:35 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-15 11:32:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200606

Powered by Google App Engine
This is Rietveld 408576698