Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1292963006: [heap] Move {hidden_string} into the root list. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Move {hidden_string} into the root list. R=hpayer@chromium.org Committed: https://crrev.com/05e843443a46f39fedeac32985a1416a221c797c Cr-Commit-Position: refs/heads/master@{#30272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -19 lines) Patch
M src/factory.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/heap.h View 3 chunks +1 line, -8 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-20 13:25:13 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 4 months ago (2015-08-20 13:27:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292963006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292963006/1
5 years, 4 months ago (2015-08-20 13:50:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-20 14:08:44 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 14:08:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05e843443a46f39fedeac32985a1416a221c797c
Cr-Commit-Position: refs/heads/master@{#30272}

Powered by Google App Engine
This is Rietveld 408576698