Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: tools/dom/templates/html/impl/impl_Node.darttemplate

Issue 1292963003: Fix identity and SVGAnimatedString issues with element_classes_test (Closed) Base URL: git@github.com:dart-lang/sdk.git@integration
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/templates/html/impl/impl_Node.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_Node.darttemplate b/tools/dom/templates/html/impl/impl_Node.darttemplate
index d871dd37161ee4ab314b539622815be627e994bb..c9330567b9fb5f163a43fe62622867e5b7daf08f 100644
--- a/tools/dom/templates/html/impl/impl_Node.darttemplate
+++ b/tools/dom/templates/html/impl/impl_Node.darttemplate
@@ -114,7 +114,12 @@ $endif
bool remove(Object object) {
if (object is! Node) return false;
Node node = object;
+$if JSINTEROP
+ // We aren't preserving identity of nodes in JSINTEROP mode
+ if (_this != node.parentNode) return false;
+$else
if (!identical(_this, node.parentNode)) return false;
+$endif
_this._removeChild(node);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698