Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1292963003: Fix identity and SVGAnimatedString issues with element_classes_test (Closed)

Created:
5 years, 4 months ago by Alan Knight
Modified:
5 years, 4 months ago
Reviewers:
terry
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@integration
Target Ref:
refs/heads/integration
Visibility:
Public.

Description

Fix identity and SVGAnimatedString issues with element_classes_test BUG= Committed: https://github.com/dart-lang/sdk/commit/e9812a7068c47a74b2d3c377c2ed7514ad379fe6

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -8 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +7 lines, -4 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 2 chunks +12 lines, -2 lines 1 comment Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_SVGElement.darttemplate View 1 chunk +13 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
Alan Knight
TBR Very ugly on the AnimatedString, and there are other instances, but we can deal ...
5 years, 4 months ago (2015-08-14 23:59:02 UTC) #2
Alan Knight
Committed patchset #1 (id:1) manually as e9812a7068c47a74b2d3c377c2ed7514ad379fe6 (presubmit successful).
5 years, 4 months ago (2015-08-14 23:59:14 UTC) #3
terry
5 years, 4 months ago (2015-08-17 14:40:29 UTC) #4
Message was sent while issue was closed. 
https://codereview.chromium.org/1292963003/diff/1/tools/dom/templates/html/im...
File tools/dom/templates/html/impl/impl_Element.darttemplate (right):

https://codereview.chromium.org/1292963003/diff/1/tools/dom/templates/html/im...
tools/dom/templates/html/impl/impl_Element.darttemplate:1267: $if JSINTEROP
Comment?

// We aren't preserving identity of nodes in JSINTEROP mode

https://codereview.chromium.org/1292963003/diff/1/tools/dom/templates/html/im...
File tools/dom/templates/html/impl/impl_SVGElement.darttemplate (right):

https://codereview.chromium.org/1292963003/diff/1/tools/dom/templates/html/im...
tools/dom/templates/html/impl/impl_SVGElement.darttemplate:158: $endif
Is it a bug that we can't create an SvgAnimatedString?  There is a create method
but the IDL doesn't expose that should we be able to construct an
SvgAnimatedString by allowing a constructor to call create?

Powered by Google App Engine
This is Rietveld 408576698