Issue 129293002: Removing GetDefaultProfileOrOffTheRecord and GetDefaultProfile(<path>) from ProfileManager's (publi…

Issue 129293002: Removing GetDefaultProfileOrOffTheRecord and GetDefaultProfile(<path>) from ProfileManager's (publi… (Closed)

Created:
6 years, 11 months ago by Mr4D (OOO till 08-26)

Modified:
6 years, 11 months ago

Reviewers:
Dmitry Polukhin, rpetterson, sky

CC:
chromium-reviews, rginda+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Removing GetDefaultProfileOrOffTheRecord and GetDefaultProfile(<path>) from ProfileManager's (public) functions. BUG=322682 TEST=covered by existing unit tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243939

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changed comment #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -73 lines)			Patch
M	chrome/browser/chrome_browser_main.cc	View		3 chunks	+14 lines, -9 lines	0 comments	Download
M	chrome/browser/profiles/profile_manager.h	View	1	2 chunks	+12 lines, -13 lines	0 comments	Download
M	chrome/browser/profiles/profile_manager.cc	View		4 chunks	+40 lines, -51 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Dmitry Polukhin

lgtm https://codereview.chromium.org/129293002/diff/1/chrome/browser/profiles/profile_manager.h File chrome/browser/profiles/profile_manager.h (right): https://codereview.chromium.org/129293002/diff/1/chrome/browser/profiles/profile_manager.h#newcode66 chrome/browser/profiles/profile_manager.h:66: // DEPRECATED: DO NOT USE unless in ChromeOS. ...

6 years, 11 months ago (2014-01-08 23:44:13 UTC) #2

Mr4D (OOO till 08-26)

Addressed! https://codereview.chromium.org/129293002/diff/1/chrome/browser/profiles/profile_manager.h File chrome/browser/profiles/profile_manager.h (right): https://codereview.chromium.org/129293002/diff/1/chrome/browser/profiles/profile_manager.h#newcode66 chrome/browser/profiles/profile_manager.h:66: // DEPRECATED: DO NOT USE unless in ChromeOS. ...

6 years, 11 months ago (2014-01-09 00:01:20 UTC) #3

rpetterson

LGTM So happy to see these functions getting deleted!

6 years, 11 months ago (2014-01-09 00:32:40 UTC) #5

Mr4D (OOO till 08-26)

Sky, can you do the owners review for the change in c/b?

6 years, 11 months ago (2014-01-09 16:07:43 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/129293002/210001

6 years, 11 months ago (2014-01-09 17:02:37 UTC) #8

Message was sent while issue was closed.

Change committed as 243939

Expand Messages | Collapse Messages