Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: service/datastore/context_test.go

Issue 1292913002: Split off serialization and key functions to their own packages. (Closed) Base URL: https://github.com/luci/gae.git@make_queries_better
Patch Set: rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « service/datastore/checkfilter_test.go ('k') | service/datastore/datastore_test.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: service/datastore/context_test.go
diff --git a/service/datastore/context_test.go b/service/datastore/context_test.go
index d1684c1a2517715c11114651a06da877e4294804..3dd6754ef9e167575c18f73f2bebd9f5021716fc 100644
--- a/service/datastore/context_test.go
+++ b/service/datastore/context_test.go
@@ -22,7 +22,7 @@ type fakeService struct{ RawInterface }
type fakeFilt struct{ RawInterface }
func (fakeFilt) NewKey(kind, stringID string, intID int64, parent Key) Key {
- return NewKey("aid", "ns", kind, stringID, intID, parent)
+ return mkKey("aid", "ns", "filteredKind", "")
}
func TestServices(t *testing.T) {
@@ -47,7 +47,7 @@ func TestServices(t *testing.T) {
})
k := Get(c).NewKey("Kind", "", 1, nil)
- So(KeysEqual(k, NewKey("aid", "ns", "Kind", "", 1, nil)), ShouldBeTrue)
+ So(k.Kind(), ShouldEqual, "filteredKind")
})
})
Convey("adding zero filters does nothing", func() {
« no previous file with comments | « service/datastore/checkfilter_test.go ('k') | service/datastore/datastore_test.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698