Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: service/datastore/serialize_test.go

Issue 1292913002: Split off serialization and key functions to their own packages. (Closed) Base URL: https://github.com/luci/gae.git@make_queries_better
Patch Set: rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « service/datastore/serialize/serialize_test.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: service/datastore/serialize_test.go
diff --git a/service/datastore/serialize_test.go b/service/datastore/serialize_test.go
deleted file mode 100644
index db9c9f67f4ed81f177a28f3965a9a513e41bd108..0000000000000000000000000000000000000000
--- a/service/datastore/serialize_test.go
+++ /dev/null
@@ -1,330 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package datastore
-
-import (
- "bytes"
- "io"
- "testing"
- "time"
-
- "github.com/luci/gae/service/blobstore"
- "github.com/luci/luci-go/common/cmpbin"
- . "github.com/smartystreets/goconvey/convey"
-)
-
-func init() {
- WritePropertyMapDeterministic = true
-}
-
-type dspmapTC struct {
- name string
- props PropertyMap
-}
-
-func TestPropertyMapSerialization(t *testing.T) {
- t.Parallel()
-
- tests := []dspmapTC{
- {
- "basic",
- PropertyMap{
- "R": {mp(false), mp(2.1), mpNI(3)},
- "S": {mp("hello"), mp("world")},
- },
- },
- {
- "keys",
- PropertyMap{
- "DS": {mp(mkKey("appy", "ns", "Foo", 7)), mp(mkKey("other", "", "Yot", "wheeep"))},
- "blobstore": {mp(blobstore.Key("sup")), mp(blobstore.Key("nerds"))},
- },
- },
- {
- "geo",
- PropertyMap{
- "G": {mp(GeoPoint{Lat: 1, Lng: 2})},
- },
- },
- {
- "data",
- PropertyMap{
- "S": {mp("sup"), mp("fool"), mp("nerd")},
- "D.Foo.Nerd": {mp([]byte("sup")), mp([]byte("fool"))},
- "B": {mp(ByteString("sup")), mp(ByteString("fool"))},
- },
- },
- {
- "time",
- PropertyMap{
- "T": {
- mp(time.Now().UTC()),
- mp(time.Now().Add(time.Second).UTC())},
- },
- },
- {
- "empty vals",
- PropertyMap{
- "T": {mp(true), mp(true)},
- "F": {mp(false), mp(false)},
- "N": {mp(nil), mp(nil)},
- "E": {},
- },
- },
- }
-
- Convey("PropertyMap serialization", t, func() {
- Convey("round trip", func() {
- for _, tc := range tests {
- tc := tc
- Convey(tc.name, func() {
- buf := &bytes.Buffer{}
- tc.props.Write(buf, WithContext)
- dec := PropertyMap{}
- err := dec.Read(buf, WithContext, "", "")
- So(err, ShouldBeNil)
- So(dec, ShouldResemble, tc.props)
- })
- }
- })
- })
-}
-
-func TestSerializationReadMisc(t *testing.T) {
- t.Parallel()
-
- Convey("Misc Serialization tests", t, func() {
- buf := &bytes.Buffer{}
- Convey("ReadKey", func() {
- Convey("good cases", func() {
- Convey("w/ ctx decodes normally w/ ctx", func() {
- k := mkKey("aid", "ns", "knd", "yo", "other", 10)
- WriteKey(buf, WithContext, k)
- dk, err := ReadKey(buf, WithContext, "", "")
- So(err, ShouldBeNil)
- So(dk, ShouldEqualKey, k)
- })
- Convey("w/ ctx decodes normally w/o ctx", func() {
- k := mkKey("aid", "ns", "knd", "yo", "other", 10)
- WriteKey(buf, WithContext, k)
- dk, err := ReadKey(buf, WithoutContext, "spam", "nerd")
- So(err, ShouldBeNil)
- So(dk, ShouldEqualKey, mkKey("spam", "nerd", "knd", "yo", "other", 10))
- })
- Convey("w/o ctx decodes normally w/ ctx", func() {
- k := mkKey("aid", "ns", "knd", "yo", "other", 10)
- WriteKey(buf, WithoutContext, k)
- dk, err := ReadKey(buf, WithContext, "spam", "nerd")
- So(err, ShouldBeNil)
- So(dk, ShouldEqualKey, mkKey("", "", "knd", "yo", "other", 10))
- })
- Convey("w/o ctx decodes normally w/o ctx", func() {
- k := mkKey("aid", "ns", "knd", "yo", "other", 10)
- WriteKey(buf, WithoutContext, k)
- dk, err := ReadKey(buf, WithoutContext, "spam", "nerd")
- So(err, ShouldBeNil)
- So(dk, ShouldEqualKey, mkKey("spam", "nerd", "knd", "yo", "other", 10))
- })
- Convey("IntIDs always sort before StringIDs", func() {
- // -1 writes as almost all 1's in the first byte under cmpbin, even
- // though it's technically not a valid key.
- k := mkKey("aid", "ns", "knd", -1)
- WriteKey(buf, WithoutContext, k)
-
- k = mkKey("aid", "ns", "knd", "hat")
- buf2 := &bytes.Buffer{}
- WriteKey(buf2, WithoutContext, k)
-
- So(bytes.Compare(buf.Bytes(), buf2.Bytes()), ShouldBeLessThan, 0)
- })
- })
-
- Convey("err cases", func() {
- Convey("nil", func() {
- _, err := ReadKey(buf, WithContext, "", "")
- So(err, ShouldEqual, io.EOF)
- })
- Convey("str", func() {
- buf.WriteString("sup")
- _, err := ReadKey(buf, WithContext, "", "")
- So(err, ShouldErrLike, "expected actualCtx")
- })
- Convey("truncated 1", func() {
- buf.WriteByte(1) // actualCtx == 1
- _, err := ReadKey(buf, WithContext, "", "")
- So(err, ShouldEqual, io.EOF)
- })
- Convey("truncated 2", func() {
- buf.WriteByte(1) // actualCtx == 1
- cmpbin.WriteString(buf, "aid")
- _, err := ReadKey(buf, WithContext, "", "")
- So(err, ShouldEqual, io.EOF)
- })
- Convey("truncated 3", func() {
- buf.WriteByte(1) // actualCtx == 1
- cmpbin.WriteString(buf, "aid")
- cmpbin.WriteString(buf, "ns")
- _, err := ReadKey(buf, WithContext, "", "")
- So(err, ShouldEqual, io.EOF)
- })
- Convey("huge key", func() {
- buf.WriteByte(1) // actualCtx == 1
- cmpbin.WriteString(buf, "aid")
- cmpbin.WriteString(buf, "ns")
- cmpbin.WriteUint(buf, 1000)
- _, err := ReadKey(buf, WithContext, "", "")
- So(err, ShouldErrLike, "huge key")
- })
- Convey("insufficient tokens", func() {
- buf.WriteByte(1) // actualCtx == 1
- cmpbin.WriteString(buf, "aid")
- cmpbin.WriteString(buf, "ns")
- cmpbin.WriteUint(buf, 2)
- _, err := ReadKey(buf, WithContext, "", "")
- So(err, ShouldEqual, io.EOF)
- })
- Convey("partial token 1", func() {
- buf.WriteByte(1) // actualCtx == 1
- cmpbin.WriteString(buf, "aid")
- cmpbin.WriteString(buf, "ns")
- cmpbin.WriteUint(buf, 2)
- cmpbin.WriteString(buf, "hi")
- _, err := ReadKey(buf, WithContext, "", "")
- So(err, ShouldEqual, io.EOF)
- })
- Convey("partial token 2", func() {
- buf.WriteByte(1) // actualCtx == 1
- cmpbin.WriteString(buf, "aid")
- cmpbin.WriteString(buf, "ns")
- cmpbin.WriteUint(buf, 2)
- cmpbin.WriteString(buf, "hi")
- buf.WriteByte(byte(PTString))
- _, err := ReadKey(buf, WithContext, "", "")
- So(err, ShouldEqual, io.EOF)
- })
- Convey("bad token (invalid type)", func() {
- buf.WriteByte(1) // actualCtx == 1
- cmpbin.WriteString(buf, "aid")
- cmpbin.WriteString(buf, "ns")
- cmpbin.WriteUint(buf, 2)
- cmpbin.WriteString(buf, "hi")
- buf.WriteByte(byte(PTBlobKey))
- _, err := ReadKey(buf, WithContext, "", "")
- So(err, ShouldErrLike, "invalid type PTBlobKey")
- })
- Convey("bad token (invalid IntID)", func() {
- buf.WriteByte(1) // actualCtx == 1
- cmpbin.WriteString(buf, "aid")
- cmpbin.WriteString(buf, "ns")
- cmpbin.WriteUint(buf, 2)
- cmpbin.WriteString(buf, "hi")
- buf.WriteByte(byte(PTInt))
- cmpbin.WriteInt(buf, -2)
- _, err := ReadKey(buf, WithContext, "", "")
- So(err, ShouldErrLike, "zero/negative")
- })
- })
- })
-
- Convey("ReadGeoPoint", func() {
- gp := GeoPoint{}
- Convey("trunc 1", func() {
- err := gp.Read(buf)
- So(err, ShouldEqual, io.EOF)
- })
- Convey("trunc 2", func() {
- cmpbin.WriteFloat64(buf, 100)
- err := gp.Read(buf)
- So(err, ShouldEqual, io.EOF)
- })
- Convey("invalid", func() {
- cmpbin.WriteFloat64(buf, 100)
- cmpbin.WriteFloat64(buf, 1000)
- err := gp.Read(buf)
- So(err, ShouldErrLike, "invalid GeoPoint")
- })
- })
-
- Convey("WriteTime", func() {
- Convey("in non-UTC!", func() {
- pst, err := time.LoadLocation("America/Los_Angeles")
- So(err, ShouldBeNil)
- So(func() {
- WriteTime(buf, time.Now().In(pst))
- }, ShouldPanic)
- })
- })
-
- Convey("ReadTime", func() {
- Convey("trunc 1", func() {
- _, err := ReadTime(buf)
- So(err, ShouldEqual, io.EOF)
- })
- })
-
- Convey("ReadProperty", func() {
- p := Property{}
- Convey("trunc 1", func() {
- err := p.Read(buf, WithContext, "", "")
- So(err, ShouldEqual, io.EOF)
- So(p.Type(), ShouldEqual, PTNull)
- So(p.Value(), ShouldBeNil)
- })
- Convey("trunc (PTBytes)", func() {
- buf.WriteByte(byte(PTBytes))
- err := p.Read(buf, WithContext, "", "")
- So(err, ShouldEqual, io.EOF)
- })
- Convey("trunc (PTBlobKey)", func() {
- buf.WriteByte(byte(PTBlobKey))
- err := p.Read(buf, WithContext, "", "")
- So(err, ShouldEqual, io.EOF)
- })
- Convey("invalid type", func() {
- buf.WriteByte(byte(PTUnknown + 1))
- err := p.Read(buf, WithContext, "", "")
- So(err, ShouldErrLike, "unknown type!")
- })
- })
-
- Convey("ReadPropertyMap", func() {
- pm := PropertyMap{}
- Convey("trunc 1", func() {
- err := pm.Read(buf, WithContext, "", "")
- So(err, ShouldEqual, io.EOF)
- })
- Convey("too many rows", func() {
- cmpbin.WriteUint(buf, 1000000)
- err := pm.Read(buf, WithContext, "", "")
- So(err, ShouldErrLike, "huge number of rows")
- })
- Convey("trunc 2", func() {
- cmpbin.WriteUint(buf, 10)
- err := pm.Read(buf, WithContext, "", "")
- So(err, ShouldEqual, io.EOF)
- })
- Convey("trunc 3", func() {
- cmpbin.WriteUint(buf, 10)
- cmpbin.WriteString(buf, "ohai")
- err := pm.Read(buf, WithContext, "", "")
- So(err, ShouldEqual, io.EOF)
- })
- Convey("too many values", func() {
- cmpbin.WriteUint(buf, 10)
- cmpbin.WriteString(buf, "ohai")
- cmpbin.WriteUint(buf, 100000)
- err := pm.Read(buf, WithContext, "", "")
- So(err, ShouldErrLike, "huge number of properties")
- })
- Convey("trunc 4", func() {
- cmpbin.WriteUint(buf, 10)
- cmpbin.WriteString(buf, "ohai")
- cmpbin.WriteUint(buf, 10)
- err := pm.Read(buf, WithContext, "", "")
- So(err, ShouldEqual, io.EOF)
- })
- })
- })
-}
« no previous file with comments | « service/datastore/serialize/serialize_test.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698