impl/dummy/dummy.go - Issue 1292913002: Split off serialization and key functions to their own packages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: impl/dummy/dummy.go

Issue 1292913002: Split off serialization and key functions to their own packages. (Closed) Base URL: https://github.com/luci/gae.git@make_queries_better

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: impl/dummy/dummy.go

diff --git a/impl/dummy/dummy.go b/impl/dummy/dummy.go

index 94978754aa3f897e1ec04ef8c31b27e55cc65da4..020c8b499433102e55d3564c675ef0a43554ed5c 100644

--- a/impl/dummy/dummy.go

+++ b/impl/dummy/dummy.go

@@ -11,6 +11,7 @@ import (

"time"

"github.com/luci/gae/service/datastore"

+ "github.com/luci/gae/service/datastore/dskey"

"github.com/luci/gae/service/info"

"github.com/luci/gae/service/memcache"

"github.com/luci/gae/service/taskqueue"

@@ -65,7 +66,7 @@ func ni() error {

type ds struct{}

func (ds) NewKey(kind string, sid string, iid int64, par datastore.Key) datastore.Key {

- return datastore.NewKey("dummy~appid", "", kind, sid, iid, par)

+ return dskey.New("dummy~appid", "", kind, sid, iid, par)

}

func (ds) DecodeKey(string) (datastore.Key, error) { panic(ni()) }

func (ds) PutMulti([]datastore.Key, []datastore.PropertyMap, datastore.PutMultiCB) error {

« no previous file with comments | « filter/dscache/support.go ('k') | impl/memory/datastore.go » ('j') | service/datastore/dskey/generic_key.go » ('J')