Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6921)

Unified Diff: chrome/browser/resources/options/pref_ui.js

Issue 12929018: Enhancements to https://codereview.chromium.org/12494033/ for zmo@ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/pref_ui.js
diff --git a/chrome/browser/resources/options/pref_ui.js b/chrome/browser/resources/options/pref_ui.js
index dd33c72eab21e0c26ef39363d934fe6ba66afae7..45ac11aef860ba5cae47525f82044dd7e5f6739a 100644
--- a/chrome/browser/resources/options/pref_ui.js
+++ b/chrome/browser/resources/options/pref_ui.js
@@ -180,7 +180,10 @@ cr.define('options', function() {
*/
updateStateFromPref_: function(event) {
var value = Boolean(event.value.value);
+ var checked = this.checked;
this.checked = this.inverted_pref ? !value : value;
+ if (checked != this.checked)
Dan Beam 2013/03/22 00:31:29 arv@: this is mildly alarming
arv (Not doing code reviews) 2013/03/22 14:35:48 Yeah, this is wrong. We already have code in place
+ cr.dispatchSimpleEvent(this, 'change', true, true);
},
};

Powered by Google App Engine
This is Rietveld 408576698