Enhancements to https://codereview.chromium.org/12494033/ for zmo@

chrome/browser/resources/options/pref_ui.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
 
   var Preferences = options.Preferences;
 
   /**
    * Allows an element to be disabled for several reasons.
@@ skipping 162 matching lines @@
                                  !this.dialogPref, this.metric);
     },
 
     /**
      * Update the checkbox state when the associated pref changes.
      * @param {Event} event Pref change event.
      * @private
      */
     updateStateFromPref_: function(event) {
       var value = Boolean(event.value.value);
+      var checked = this.checked;
       this.checked = this.inverted_pref ? !value : value;
+      if (checked != this.checked)

[Dan Beam, 2013/03/22 00:31:29]

arv@: this is mildly alarming

[arv (Not doing code reviews), 2013/03/22 14:35:48]

Yeah, this is wrong. We already have code in place for updating the UI when a
pref changes, we should not simulate user actions.

+        cr.dispatchSimpleEvent(this, 'change', true, true);
     },
   };
 
   /**
    * Whether the mapping between checkbox state and associated pref is inverted.
    * @type {boolean}
    */
   cr.defineProperty(PrefCheckbox, 'inverted_pref', cr.PropertyKind.BOOL_ATTR);
 
   /////////////////////////////////////////////////////////////////////////////
@@ skipping 323 matching lines @@
     PrefCheckbox: PrefCheckbox,
     PrefNumber: PrefNumber,
     PrefRadio: PrefRadio,
     PrefRange: PrefRange,
     PrefSelect: PrefSelect,
     PrefTextField: PrefTextField,
     PrefButton: PrefButton
   };
 
 });