Identity API: Pop-up a sign-in dialog if gaia credentials are bad

chrome/browser/ui/webui/signin/login_ui_service.cc

Index: chrome/browser/ui/webui/signin/login_ui_service.cc
diff --git a/chrome/browser/ui/webui/signin/login_ui_service.cc b/chrome/browser/ui/webui/signin/login_ui_service.cc
index 69b2bb0694fb9a02698f55e3c27b64428e0cbd59..31ad5fc2554853e456a2dff65d05eda795efc7d9 100644
--- a/chrome/browser/ui/webui/signin/login_ui_service.cc
+++ b/chrome/browser/ui/webui/signin/login_ui_service.cc
@@ -6,6 +6,7 @@
 
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_navigator.h"
 #include "chrome/browser/ui/chrome_pages.h"
 #include "chrome/browser/ui/host_desktop.h"
@@ -42,23 +43,7 @@ void LoginUIService::LoginUIClosed(LoginUI* ui) {
 }
 
 void LoginUIService::ShowLoginPopup() {
-  if (current_login_ui()) {
-    current_login_ui()->FocusUI();
-    return;
-  }
-
-  Browser* browser =
-      new Browser(Browser::CreateParams(Browser::TYPE_POPUP, profile_,
-                                        chrome::GetActiveDesktop()));
-  // TODO(munjal): Change the source from SOURCE_NTP_LINK to something else
-  // once we have added a new source for extension API.
-  GURL signin_url(SyncPromoUI::GetSyncPromoURL(GURL(),
-                                               SyncPromoUI::SOURCE_NTP_LINK,
-                                               true));
-  chrome::NavigateParams params(browser,
-                                signin_url,
-                                content::PAGE_TRANSITION_AUTO_TOPLEVEL);
-  params.disposition = CURRENT_TAB;
-  params.window_action = chrome::NavigateParams::SHOW_WINDOW;
-  chrome::Navigate(&params);
+  Browser* browser = FindOrCreateTabbedBrowser(profile_,

[Evan Stade, 2013/04/04 01:25:19]

this isn't implemented on Android. If Android started trying to use this
function, I think it would fail to link.

[Michael Courage, 2013/04/04 03:38:39]

Good to know. This function is mostly used by app/extension APIs. There's some
upcoming work to improve sign-in for apps, so we should probably refactor this
code into an app/extension specific location as part of that.

+                                               chrome::GetActiveDesktop());
+  chrome::ShowBrowserSignin(browser, SyncPromoUI::SOURCE_APP_LAUNCHER);
 }