Identity API: Pop-up a sign-in dialog if gaia credentials are bad

chrome/browser/extensions/api/identity/identity_signin_flow.cc

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/api/identity/identity_signin_flow.h"
+
+#include "chrome/browser/signin/token_service.h"
+#include "chrome/browser/signin/token_service_factory.h"
+#include "chrome/browser/ui/webui/signin/login_ui_service.h"
+#include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
+#include "chrome/common/chrome_notification_types.h"
+#include "content/public/browser/notification_details.h"
+#include "google_apis/gaia/gaia_constants.h"
+
+namespace extensions {
+
+IdentitySigninFlow::IdentitySigninFlow(Delegate* delegate, Profile* profile)
+    : delegate_(delegate),
+      profile_(profile) {
+}
+
+IdentitySigninFlow::~IdentitySigninFlow() {
+}
+
+void IdentitySigninFlow::Start() {
+#if !defined(OS_CHROMEOS)
+  DCHECK(delegate_);
+  TokenService* token_service = TokenServiceFactory::GetForProfile(profile_);
+  registrar_.Add(this,
+                 chrome::NOTIFICATION_TOKEN_AVAILABLE,
+                 content::Source<TokenService>(token_service));
+
+  LoginUIService* login_ui_service =
+      LoginUIServiceFactory::GetForProfile(profile_);
+  login_ui_service->ShowLoginPopup();
+#else
+  // On Chrome OS, the user has to log out to re-establish credentials. Let the
+  // global error popup handle everything.
+  delegate_->SigninFailed();
+#endif
+}
+
+void IdentitySigninFlow::Observe(int type,
+                                 const content::NotificationSource& source,
+                                 const content::NotificationDetails& details) {
+  CHECK(type == chrome::NOTIFICATION_TOKEN_AVAILABLE);
+  TokenService::TokenAvailableDetails* token_details =
+      content::Details<TokenService::TokenAvailableDetails>(details).ptr();
+  if (token_details->service() == GaiaConstants::kGaiaOAuth2LoginRefreshToken)
+    delegate_->SigninSuccess(token_details->token());
+}

[Roger Tawa OOO till Jul 10th, 2013/04/02 14:41:07]

What happens if this notification is never sent after calling ShowLoginPopup()?

[Michael Courage, 2013/04/02 17:17:49]

The (async) getAuthToken call will not complete until a token becomes available.
I'd like to be able to watch for an aborted sign-in flow through a SigninTracker
or LoginUIService, but that's a larger change that I didn't want to hold up this
fix for in M27. I'll file a separate issue for handling aborted sign-ins.

[Roger Tawa OOO till Jul 10th, 2013/04/02 18:00:24]

Is the plan to also resolve this separate issue in M27?  If the getAuthToken()
call never completes, now does the caller deal with this situation?  Can they
cancel the call?

+
+}  // namespace extensions