Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1292893005: Deflake virtual/threaded/animations/responsive-neutral-keyframes.html (Closed)

Created:
5 years, 4 months ago by alancutter (OOO until 2018)
Modified:
5 years, 4 months ago
Reviewers:
Timothy Loh
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Deflake virtual/threaded/animations/responsive-neutral-keyframes.html This test was relying on animation events to function. This change updates the test to use requestAnimationFrame to be more deterministic and avoid timing out when running under threaded debug. BUG=469683 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200772

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -51 lines) Patch
M LayoutTests/TestExpectations View 2 chunks +0 lines, -3 lines 0 comments Download
M LayoutTests/animations/responsive-neutral-keyframes.html View 1 chunk +34 lines, -48 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292893005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292893005/1
5 years, 4 months ago (2015-08-18 08:20:18 UTC) #3
alancutter (OOO until 2018)
5 years, 4 months ago (2015-08-18 08:23:05 UTC) #4
Timothy Loh
lgtm
5 years, 4 months ago (2015-08-18 08:26:49 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-18 09:04:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292893005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292893005/1
5 years, 4 months ago (2015-08-19 00:54:16 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 00:58:42 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200772

Powered by Google App Engine
This is Rietveld 408576698