Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1292863003: update-w3c-deps import using blink e60a8575c2fa4bc64b804926b956b695a3ac158e: (Closed)

Created:
5 years, 4 months ago by kojii
Modified:
5 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, shans, rjwright, blink-reviews-animation_chromium.org, darktears, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

update-w3c-deps import using blink e60a8575c2fa4bc64b804926b956b695a3ac158e: imported csswg-test@adb1c28f977cb1f4ee22a44d6f4a6f1055682ff1 imported web-platform-tests@1e70f2fac661cdb44d500ae8fe545c710179cbef * html/dom/documents/dom-tree-accessors/Document.currentScript.html now makes XMLHTTPRequest to "/" and throws, thus skip it now. * html/webappapis/animation-frames - 1 new test fails, "-expected" added. * shadow-dom - 2 failing tests were removed in upstream. - 1 new crash in focus-navigation. * css-writing-modes-3 - 4 new ref tests fail. * NOPRESUBMIT=true because of tab characters in shadow-dom/testcommon.js. NOPRESUBMIT=true TBR=dpranke@chromium.org,jsbell@chromium.org,tkent@chromium.org,hayato@chromium.org,kochi@chromium.org BUG=490511, 492664, 505364 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200880

Patch Set 1 #

Patch Set 2 : dom-tree-accessors/Document.currentScript.html can timeout #

Total comments: 1

Patch Set 3 : tkent review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+386 lines, -469 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M LayoutTests/W3CImportExpectations View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/imported/csswg-test/css-writing-modes-3/caption-side-vlr-007.xht View 1 chunk +64 lines, -0 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/caption-side-vlr-007-expected.xht View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/caption-side-vlr-009.xht View 1 chunk +27 lines, -15 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/caption-side-vlr-009-expected.xht View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/imported/csswg-test/css-writing-modes-3/caption-side-vrl-006.xht View 1 chunk +63 lines, -0 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/caption-side-vrl-006-expected.xht View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/caption-side-vrl-008.xht View 1 chunk +27 lines, -15 lines 0 comments Download
A + LayoutTests/imported/csswg-test/css-writing-modes-3/caption-side-vrl-008-expected.xht View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/imported/csswg-test/css-writing-modes-3/support/pass-cdts-first-page-vlr-003.png View Binary file 0 comments Download
A LayoutTests/imported/csswg-test/css-writing-modes-3/support/pass-cdts-first-page-vrl-002.png View Binary file 0 comments Download
M LayoutTests/imported/web-platform-tests/html/dom/documents/dom-tree-accessors/Document.currentScript.html View 1 2 1 chunk +0 lines, -45 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/html/webappapis/animation-frames/callback-exception.html View 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/html/webappapis/animation-frames/callback-invoked.html View 1 chunk +22 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/html/webappapis/animation-frames/cancel-invoked.html View 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/html/webappapis/animation-frames/idlharness.html View 1 chunk +50 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/html/webappapis/animation-frames/idlharness-expected.txt View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/imported/web-platform-tests/html/webappapis/animation-frames/same-dispatch-time.html View 1 chunk +31 lines, -0 lines 0 comments Download
D LayoutTests/imported/web-platform-tests/shadow-dom/elements-and-dom-objects/the-content-html-element/test-004.html View 1 chunk +0 lines, -163 lines 0 comments Download
D LayoutTests/imported/web-platform-tests/shadow-dom/elements-and-dom-objects/the-shadow-html-element/test-003.html View 1 chunk +0 lines, -189 lines 0 comments Download
M LayoutTests/imported/web-platform-tests/shadow-dom/events/event-dispatch/test-001.html View 7 chunks +18 lines, -18 lines 0 comments Download
M LayoutTests/imported/web-platform-tests/shadow-dom/events/event-retargeting/test-004.html View 7 chunks +15 lines, -15 lines 0 comments Download
M LayoutTests/imported/web-platform-tests/shadow-dom/testcommon.js View 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292863003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292863003/20001
5 years, 4 months ago (2015-08-20 04:58:42 UTC) #2
tkent
https://codereview.chromium.org/1292863003/diff/20001/LayoutTests/TestExpectations File LayoutTests/TestExpectations (right): https://codereview.chromium.org/1292863003/diff/20001/LayoutTests/TestExpectations#newcode383 LayoutTests/TestExpectations:383: crbug.com/490511 imported/web-platform-tests/html/webappapis/animation-frames/idlharness.html [ Failure ] Would you check in ...
5 years, 4 months ago (2015-08-20 05:02:11 UTC) #4
tkent
> html/dom/documents/dom-tree-accessors/Document.currentScript.html > now makes XMLHTTPRequest to "/" and throws, thus timeout. It means the ...
5 years, 4 months ago (2015-08-20 05:03:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/90444)
5 years, 4 months ago (2015-08-20 05:07:08 UTC) #7
kojii
PTAL. Description was updated to reflect the changes. On 2015/08/20 05:02:11, tkent wrote: > https://codereview.chromium.org/1292863003/diff/20001/LayoutTests/TestExpectations ...
5 years, 4 months ago (2015-08-20 06:25:01 UTC) #8
tkent
lgtm
5 years, 4 months ago (2015-08-20 06:29:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292863003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292863003/40001
5 years, 4 months ago (2015-08-20 06:29:42 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/90480)
5 years, 4 months ago (2015-08-20 06:38:11 UTC) #13
tkent
Please try NOPRESUBMIT=true.
5 years, 4 months ago (2015-08-20 06:42:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292863003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292863003/40001
5 years, 4 months ago (2015-08-20 06:43:35 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 06:44:17 UTC) #17
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200880

Powered by Google App Engine
This is Rietveld 408576698