Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Unified Diff: build/common.gypi

Issue 129283003: Enable unwind-support for all non-official builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index fac1a9e80a39449f91bec51eafc8c451240ea106..aa13b0cf7db441f14be05644f5bdab23ce745858 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1112,6 +1112,8 @@
'linux_strip_binary%': 0,
# Strip the test binaries needed for Linux reliability tests.
'linux_strip_reliability_tests%': 0,
+ # If we want stack unwind support for backtrace().
+ 'unwind_tables%': 1,
# Enable TCMalloc.
'linux_use_tcmalloc%': 1,
@@ -1289,6 +1291,10 @@
# symbols from official builds.
['(branding=="Chrome" and buildtype=="Official")', {
'linux_dump_symbols%': 1,
+
+ # Omit unwind support in official builds to save space. We can use
+ # breakpad for these builds.
+ 'unwind_tables%': 0,
}],
],
}], # os_posix==1 and OS!="mac" and OS!="ios"
@@ -3077,14 +3083,6 @@
}],
],
}],
- # Can be omitted to reduce output size. Does not seem to affect
- # crash reporting.
- ['target_arch=="ia32"', {
- 'cflags': [
- '-fno-unwind-tables',
- '-fno-asynchronous-unwind-tables',
- ],
- }],
],
},
},
@@ -3562,6 +3560,11 @@
}],
],
}],
+ ['unwind_tables==1', {
+ 'cflags': ['-funwind-tables'],
+ }, {
+ 'cflags': ['-fno-unwind-tables', '-fno-asynchronous-unwind-tables'],
+ }],
['linux_use_tcmalloc==0 and android_use_tcmalloc==0', {
'defines': ['NO_TCMALLOC'],
}],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698