Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 129283003: Enable unwind-support for all non-official builds (Closed)

Created:
6 years, 11 months ago by spang
Modified:
6 years, 11 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Enable unwind support for all non-official builds This makes unwind support consistent on Linux (used by base::debug::StackTrace). A combination of arch-specific toolchain defaults and arch-specific cflags made the previous behavior inconsistent. Unwind tables are useful for development and much cheaper than debuginfo, so enable them for all non-official builds. TEST=build for ia32, x64, arm (compared defaults & official) BUG=180975 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243919

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M build/common.gypi View 4 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
spang
Discussion: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/146MR0gLr28
6 years, 11 months ago (2014-01-08 21:28:04 UTC) #1
Paweł Hajdan Jr.
LGTM
6 years, 11 months ago (2014-01-09 07:47:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/129283003/1
6 years, 11 months ago (2014-01-09 15:26:30 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 17:32:54 UTC) #4
Message was sent while issue was closed.
Change committed as 243919

Powered by Google App Engine
This is Rietveld 408576698