Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1292753009: sandbox/linux: move ErrorCode into bpf_dsl (Closed)

Created:
5 years, 4 months ago by mdempsky
Modified:
5 years, 4 months ago
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bpf_dsl-deps
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sandbox/linux: move ErrorCode into bpf_dsl Removes the cyclic dependencies between bpf_dsl and seccomp-bpf. BUG=449357 Committed: https://crrev.com/3909ebfa69566f7374a6900e63cd4d3c73a35378 Cr-Commit-Position: refs/heads/master@{#344610}

Patch Set 1 #

Patch Set 2 : Fix nonsfi build #

Patch Set 3 : Rebase and cleanup test code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -543 lines) Patch
M sandbox/linux/BUILD.gn View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M sandbox/linux/bpf_dsl/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc View 1 2 3 chunks +2 lines, -54 lines 0 comments Download
A + sandbox/linux/bpf_dsl/errorcode.h View 1 2 4 chunks +13 lines, -14 lines 0 comments Download
A + sandbox/linux/bpf_dsl/errorcode.cc View 1 2 6 chunks +15 lines, -14 lines 0 comments Download
A sandbox/linux/bpf_dsl/errorcode_unittest.cc View 1 2 1 chunk +120 lines, -0 lines 0 comments Download
M sandbox/linux/bpf_dsl/policy_compiler.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/bpf_dsl/policy_compiler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A sandbox/linux/bpf_dsl/test_trap_registry.h View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
A sandbox/linux/bpf_dsl/test_trap_registry.cc View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
A sandbox/linux/bpf_dsl/test_trap_registry_unittest.cc View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
M sandbox/linux/bpf_dsl/verifier.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/integration_tests/bpf_dsl_seccomp_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/sandbox_linux.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/linux/sandbox_linux_nacl_nonsfi.gyp View 1 2 chunks +1 line, -1 line 0 comments Download
M sandbox/linux/sandbox_linux_test_sources.gypi View 1 2 1 chunk +4 lines, -1 line 0 comments Download
D sandbox/linux/seccomp-bpf/errorcode.h View 1 2 1 chunk +0 lines, -206 lines 0 comments Download
D sandbox/linux/seccomp-bpf/errorcode.cc View 1 2 1 chunk +0 lines, -119 lines 0 comments Download
D sandbox/linux/seccomp-bpf/errorcode_unittest.cc View 1 chunk +0 lines, -120 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
mdempsky
This CL builds on top of https://codereview.chromium.org/1302043002/, but it's pretty logically distinct. It touches a ...
5 years, 4 months ago (2015-08-20 17:16:11 UTC) #2
rickyz (no longer on Chrome)
lgtm Thanks for taking the opportunity to clang-format!
5 years, 4 months ago (2015-08-20 22:41:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292753009/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292753009/40001
5 years, 4 months ago (2015-08-20 22:44:36 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-20 23:18:25 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 23:19:04 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3909ebfa69566f7374a6900e63cd4d3c73a35378
Cr-Commit-Position: refs/heads/master@{#344610}

Powered by Google App Engine
This is Rietveld 408576698