src/full-codegen/full-codegen.cc - Issue 1292753007: [es6] Parameter scopes for sloppy eval

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/full-codegen.cc

Issue 1292753007: [es6] Parameter scopes for sloppy eval (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/full-codegen.cc

diff --git a/src/full-codegen/full-codegen.cc b/src/full-codegen/full-codegen.cc

index bb7b637d4224e0764e1f72d803d46f318b9dc472..51fa09e56b56d89e787060c8868569f70cf2fd58 100644

--- a/src/full-codegen/full-codegen.cc

+++ b/src/full-codegen/full-codegen.cc

@@ -1548,7 +1548,7 @@ FullCodeGenerator::EnterBlockScopeIfNeeded::EnterBlockScopeIfNeeded(

codegen_->PrepareForBailoutForId(entry_id, NO_REGISTERS);

needs_block_context_ = false;

} else {

- needs_block_context_ = scope->ContextLocalCount() > 0;

+ needs_block_context_ = scope->NeedsContext();

codegen_->scope_ = scope;

{

if (needs_block_context_) {

« no previous file with comments | « src/factory.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »