src/hydrogen.cc - Issue 1292753007: [es6] Parameter scopes for sloppy eval

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 1292753007: [es6] Parameter scopes for sloppy eval (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index d5868f399f0cc02d72d497fa3309175b250d4c6c..dcd21d7bc4869b5e405e813d966854c00beeb72f 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -4690,7 +4690,7 @@ void HOptimizedGraphBuilder::VisitBlock(Block* stmt) {

{ BreakAndContinueScope push(&break_info, this);

if (scope != NULL) {

- if (scope->ContextLocalCount() > 0) {

+ if (scope->NeedsContext()) {

// Load the function object.

Scope* declaration_scope = scope->DeclarationScope();

HInstruction* function;