|
|
Description[Android] Start requiring Google Play services 7.8
It is contained in the SDK manager package google_play_services
version 26. Running hooks/gyp/gn will check the local version
and prompt to run the update if it is needed.
BUG=491280, 477059
Committed: https://crrev.com/0c50961006cd76b2a20f445a6f296535664e777d
Cr-Commit-Position: refs/heads/master@{#343862}
Patch Set 1 #
Messages
Total messages: 19 (4 generated)
dgn@chromium.org changed reviewers: + cjhopman@chromium.org, hinoka@google.com
cjhopman@: PTAL. This will make the bots pick up the new zip running 7.8 sdk that was pushed yesterday. Devs will see a message looking like "Error while checking Android SDK extras versions. Version 26 or greater is required for the package "extra-google-google_play_services". Version 25 found. Please run build/install-android-sdks.sh to update it." when running gyp hinoka@: I uploaded the v26 zip to the cloud storage. Is there anything special I need to do before I submit this patch and the bots start using it?
dgn@chromium.org changed reviewers: + scottmg@chromium.org
scottmg@: PTAL. For more context, this builds up on changes related to crbug.com/490091
On 2015/08/14 15:37:51, dgn wrote: > scottmg@: PTAL. For more context, this builds up on changes related to > crbug.com/490091 I will leave this to Chris as he's more familiar with Android.
dgn@chromium.org changed reviewers: + jbudorick@chromium.org
I think today is Chris' last day on chrome, which is why I sent it to you. Do you know which reviewer would be recommended then? jbudorick@ maybe? He reviewed some related code in build/android but is not owner of build/
On 2015/08/14 at 16:07:34, dgn wrote: > I think today is Chris' last day on chrome, which is why I sent it to you. Do you know which reviewer would be recommended then? jbudorick@ maybe? He reviewed some related code in build/android but is not owner of build/ Yeah, I'd be happy to review this. I'll need to read up on the context a bit, though, and I obviously can't provide OWNERS.
On 2015/08/14 16:14:29, jbudorick wrote: > On 2015/08/14 at 16:07:34, dgn wrote: > > I think today is Chris' last day on chrome, which is why I sent it to you. Do > you know which reviewer would be recommended then? jbudorick@ maybe? He reviewed > some related code in build/android but is not owner of build/ > > Yeah, I'd be happy to review this. I'll need to read up on the context a bit, > though, and I obviously can't provide OWNERS. Ah, sorry to hear you're leaving Chris. :) John, please feel free to send a CL to add yourself to build/OWNERS. It's a very broad (and sometimes subtle) directory, so we just try to redirect reviews to the person who has the most familiarity.
On 2015/08/14 16:41:44, scottmg wrote: > On 2015/08/14 16:14:29, jbudorick wrote: > > On 2015/08/14 at 16:07:34, dgn wrote: > > > I think today is Chris' last day on chrome, which is why I sent it to you. > Do > > you know which reviewer would be recommended then? jbudorick@ maybe? He > reviewed > > some related code in build/android but is not owner of build/ > > > > Yeah, I'd be happy to review this. I'll need to read up on the context a bit, > > though, and I obviously can't provide OWNERS. > > Ah, sorry to hear you're leaving Chris. :) > > John, please feel free to send a CL to add yourself to build/OWNERS. It's a very > broad (and sometimes subtle) directory, so we just try to redirect reviews to > the person who has the most familiarity. Or maybe we should start moving android specific things to build/android?
On 2015/08/14 17:17:08, dgn wrote: > On 2015/08/14 16:41:44, scottmg wrote: > > On 2015/08/14 16:14:29, jbudorick wrote: > > > On 2015/08/14 at 16:07:34, dgn wrote: > > > > I think today is Chris' last day on chrome, which is why I sent it to you. > > Do > > > you know which reviewer would be recommended then? jbudorick@ maybe? He > > reviewed > > > some related code in build/android but is not owner of build/ > > > > > > Yeah, I'd be happy to review this. I'll need to read up on the context a > bit, > > > though, and I obviously can't provide OWNERS. > > > > Ah, sorry to hear you're leaving Chris. :) > > > > John, please feel free to send a CL to add yourself to build/OWNERS. It's a > very > > broad (and sometimes subtle) directory, so we just try to redirect reviews to > > the person who has the most familiarity. > > Or maybe we should start moving android specific things to build/android? Is there anything blocking this other than a formal approval from OWNER? We have an invalidation changed blocked on this roll
On 2015/08/17 at 18:56:56, yfriedman wrote: > On 2015/08/14 17:17:08, dgn wrote: > > On 2015/08/14 16:41:44, scottmg wrote: > > > On 2015/08/14 16:14:29, jbudorick wrote: > > > > On 2015/08/14 at 16:07:34, dgn wrote: > > > > > I think today is Chris' last day on chrome, which is why I sent it to you. > > > Do > > > > you know which reviewer would be recommended then? jbudorick@ maybe? He > > > reviewed > > > > some related code in build/android but is not owner of build/ > > > > > > > > Yeah, I'd be happy to review this. I'll need to read up on the context a > > bit, > > > > though, and I obviously can't provide OWNERS. > > > > > > Ah, sorry to hear you're leaving Chris. :) > > > > > > John, please feel free to send a CL to add yourself to build/OWNERS. It's a > > very > > > broad (and sometimes subtle) directory, so we just try to redirect reviews to > > > the person who has the most familiarity. > > > > Or maybe we should start moving android specific things to build/android? > > Is there anything blocking this other than a formal approval from OWNER? We have an invalidation changed blocked on this roll I'm looking at it. Just want to make sure everything's ok on the GCS side.
lgtm
On 2015/08/17 19:04:33, jbudorick wrote: > lgtm Thanks! I'll commit tomorrow morning, so that I have time to fix problems before the US wakes up and starts committing like crazy.
On 2015/08/17 19:13:41, dgn wrote: > On 2015/08/17 19:04:33, jbudorick wrote: > > lgtm > > Thanks! I'll commit tomorrow morning, so that I have time to fix problems before > the US wakes up and starts committing like crazy. *eventual problems (everything should be fine!)
The CQ bit was checked by dgn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292753002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0c50961006cd76b2a20f445a6f296535664e777d Cr-Commit-Position: refs/heads/master@{#343862} |