Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 1292753002: [Android] Start requiring Google Play services 7.8 (Closed)

Created:
5 years, 4 months ago by dgn
Modified:
5 years, 4 months ago
CC:
chromium-reviews, Khushal
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Start requiring Google Play services 7.8 It is contained in the SDK manager package google_play_services version 26. Running hooks/gyp/gn will check the local version and prompt to run the update if it is needed. BUG=491280, 477059 Committed: https://crrev.com/0c50961006cd76b2a20f445a6f296535664e777d Cr-Commit-Position: refs/heads/master@{#343862}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android_sdk_extras.json View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (4 generated)
dgn
cjhopman@: PTAL. This will make the bots pick up the new zip running 7.8 sdk ...
5 years, 4 months ago (2015-08-14 14:48:02 UTC) #2
dgn
scottmg@: PTAL. For more context, this builds up on changes related to crbug.com/490091
5 years, 4 months ago (2015-08-14 15:37:51 UTC) #4
scottmg
On 2015/08/14 15:37:51, dgn wrote: > scottmg@: PTAL. For more context, this builds up on ...
5 years, 4 months ago (2015-08-14 15:57:27 UTC) #5
dgn
I think today is Chris' last day on chrome, which is why I sent it ...
5 years, 4 months ago (2015-08-14 16:07:34 UTC) #7
jbudorick
On 2015/08/14 at 16:07:34, dgn wrote: > I think today is Chris' last day on ...
5 years, 4 months ago (2015-08-14 16:14:29 UTC) #8
scottmg
On 2015/08/14 16:14:29, jbudorick wrote: > On 2015/08/14 at 16:07:34, dgn wrote: > > I ...
5 years, 4 months ago (2015-08-14 16:41:44 UTC) #9
dgn
On 2015/08/14 16:41:44, scottmg wrote: > On 2015/08/14 16:14:29, jbudorick wrote: > > On 2015/08/14 ...
5 years, 4 months ago (2015-08-14 17:17:08 UTC) #10
Yaron
On 2015/08/14 17:17:08, dgn wrote: > On 2015/08/14 16:41:44, scottmg wrote: > > On 2015/08/14 ...
5 years, 4 months ago (2015-08-17 18:56:56 UTC) #11
jbudorick
On 2015/08/17 at 18:56:56, yfriedman wrote: > On 2015/08/14 17:17:08, dgn wrote: > > On ...
5 years, 4 months ago (2015-08-17 18:57:28 UTC) #12
jbudorick
lgtm
5 years, 4 months ago (2015-08-17 19:04:33 UTC) #13
dgn
On 2015/08/17 19:04:33, jbudorick wrote: > lgtm Thanks! I'll commit tomorrow morning, so that I ...
5 years, 4 months ago (2015-08-17 19:13:41 UTC) #14
dgn
On 2015/08/17 19:13:41, dgn wrote: > On 2015/08/17 19:04:33, jbudorick wrote: > > lgtm > ...
5 years, 4 months ago (2015-08-17 19:14:13 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292753002/1
5 years, 4 months ago (2015-08-18 08:46:35 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 08:59:41 UTC) #18
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 09:00:24 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c50961006cd76b2a20f445a6f296535664e777d
Cr-Commit-Position: refs/heads/master@{#343862}

Powered by Google App Engine
This is Rietveld 408576698