Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1292743002: New flag --perf_basic_prof_only_functions (Closed)

Created:
5 years, 4 months ago by ofrobots
Modified:
5 years, 3 months ago
Reviewers:
danno, Michael Hablich
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

New flag --perf_basic_prof_only_functions Restricts linux perf-event code range reporting to functions only (i.e. on stubs.) While this makes the gathered ticks less accurate, it reduces the growth of the /tmp/perf-${pid}.map file. BUG=v8:3453 R=hablich@chromium.org,danno@chromium.org LOG=N Committed: https://crrev.com/9da3ab661fe7190fcb99bd99db30cf95913d3659 Cr-Commit-Position: refs/heads/master@{#30179}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/flag-definitions.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/log.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
danno
lgtm
5 years, 4 months ago (2015-08-14 14:15:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292743002/1
5 years, 4 months ago (2015-08-14 14:15:39 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/4924)
5 years, 4 months ago (2015-08-14 14:18:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292743002/1
5 years, 4 months ago (2015-08-14 14:50:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-14 14:51:56 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9da3ab661fe7190fcb99bd99db30cf95913d3659 Cr-Commit-Position: refs/heads/master@{#30179}
5 years, 4 months ago (2015-08-14 14:52:18 UTC) #9
ofrobots
5 years, 3 months ago (2015-09-17 19:01:28 UTC) #10
Message was sent while issue was closed.
Not sure why the second patch-set showed up here. I was trying to create a new
code-review for it. Please ignore.

Powered by Google App Engine
This is Rietveld 408576698