Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 1292703004: Remove tests svg/as-background-image/animated-svg-animation-control.html (Closed)

Created:
5 years, 4 months ago by fs
Modified:
5 years, 4 months ago
Reviewers:
pdr.
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove tests svg/as-background-image/animated-svg-animation-control.html This test has been flaky all along because the sequence of events it tries to observe is not fully observable. There's still some coverage of the reset-animation-when-no-longer-running case elsewhere. BUG=522652 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/svg/as-background-image/animated-svg-animation-control.html View 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/svg/as-background-image/animated-svg-animation-control-expected.html View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
I really have no good way forward for how to stabilize this test - so ...
5 years, 4 months ago (2015-08-20 11:06:34 UTC) #2
pdr.
lgtm These aren't really testable because we can't poke through to the image's animation timeline. ...
5 years, 4 months ago (2015-08-21 21:54:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1292703004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1292703004/1
5 years, 4 months ago (2015-08-21 21:55:24 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 22:37:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201021

Powered by Google App Engine
This is Rietveld 408576698